Skip to content

Commit 5196e09

Browse files
Merge pull request #398 from AayushSabharwal/as/fix-tests
test: add additional guesses
2 parents 9362b66 + 325ede8 commit 5196e09

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

docs/src/tutorials/input_component.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ end
204204
205205
Symbolics.@register_symbolic get_sampled_data(t)
206206
207-
function System(; name)
207+
function CustomSystem(; name)
208208
vars = @variables f(t)=0 x(t)=0 dx(t)=0 ddx(t)=0
209209
pars = @parameters m=10 k=1000 d=1
210210
@@ -216,7 +216,7 @@ function System(; name)
216216
System(eqs, t, vars, pars; name)
217217
end
218218
219-
@named system = System()
219+
@named system = CustomSystem()
220220
sys = mtkcompile(system)
221221
prob = ODEProblem(sys, [], (0, time[end]))
222222
@@ -248,7 +248,7 @@ using ModelingToolkit: t_nounits as t, D_nounits as D
248248
using ModelingToolkitStandardLibrary.Blocks
249249
using OrdinaryDiffEq
250250

251-
function System(; name)
251+
function SampledDataSystem(; name)
252252
src = SampledData(Float64, name = :src)
253253

254254
vars = @variables f(t)=0 x(t)=0 dx(t)=0 ddx(t)=0
@@ -262,7 +262,7 @@ function System(; name)
262262
System(eqs, t, vars, pars; systems = [src], name)
263263
end
264264

265-
@named system = System()
265+
@named system = SampledDataSystem()
266266
sys = mtkcompile(system, split = false)
267267
s = complete(system)
268268

test/Electrical/analog.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ end
7272
connect(R2.n, voltage.n, ground.g)]
7373

7474
@named model = System(connections, t,
75-
systems = [R0, R1, R2, source, short, voltage, ground]; guesses = [R2.v => 0.0])
75+
systems = [R0, R1, R2, source, short, voltage, ground]; guesses = [R2.v => 0.0, R1.v => 0.0])
7676
sys = mtkcompile(model)
7777
prob = ODEProblem(sys, [], (0, 2.0))
7878
sol = solve(prob, Rodas4()) # has no state; does not work with Tsit5
@@ -867,7 +867,7 @@ end
867867

868868
@mtkcompile sys = SimplePNPCircuitSubstrate(V_b = 0.70)
869869

870-
prob = ODEProblem(sys, [sys.Q1.c.i => 0.0], (0.0, 10.0))
870+
prob = ODEProblem(sys, [sys.Q1.c.i => 0.0], (0.0, 10.0); guesses = [sys.Q1.I_sub => 1.0])
871871
sol = solve(prob)
872872

873873
@test isapprox(

0 commit comments

Comments
 (0)