Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for non-string types #1

Open
tabakerov opened this issue Jan 29, 2018 · 1 comment
Open

Add support for non-string types #1

tabakerov opened this issue Jan 29, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@tabakerov
Copy link

This function right now doesn't support non-string types.
So if I do dotnet saturn gen Post Posts id:string title:string body:string is_published:bool I'll get errors at li [] [ strong [] [rawText "Is_published: "]; rawText o.is_published ] (and some similar errors around) where rawText is expecting string and not bool so I need to do .ToString() conversion.

@Krzysztof-Cieslak
Copy link
Member

Yes, I think in general the generator tooling was tested only on strings - it was not really a huge priority for me so far.

Adding support for different types is important for couple of places - generated views, mockup validaition layer (checking isNull on value type [boool, int etc] won't work], and migration scripts (where types passed to generator should be transformed into appropriate DB types [ and this probably should depend on the DB that is used, but adding supports for more DBs is something for seperate issue ;) ] )

@Krzysztof-Cieslak Krzysztof-Cieslak added the enhancement New feature or request label Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants