Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for twitch preview avability before sending notification #106

Open
Satont opened this issue May 22, 2023 · 1 comment · May be fixed by #114
Open

Check for twitch preview avability before sending notification #106

Satont opened this issue May 22, 2023 · 1 comment · May be fixed by #114
Assignees
@Satont

Comments

@Satont
Copy link
Owner

Satont commented May 22, 2023 •
edited
Loading

Twitch can return empty image with non 200 statuscode if we requesting image to fast after stream starts. We can check this in sender service, and do incremental check on availability of image.

But we must not block main gorutines then, if we are in retrying loop.
@Satont Satont self-assigned this May 22, 2023
@Satont
Copy link
Owner Author

Satont commented May 22, 2023

/cc @danilluk1

Maybe you want to do that.

@danluki danluki linked a pull request Nov 11, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Satont Satont

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: message queue danluki/twitch-notifier
1 participant
@Satont