Address reviewer comments

Author: synkd

manifester/commands.py

@@ -61,7 +61,7 @@ def delete(allocations, all_, remove_manifest_file):
             )
             if remove_manifest_file:
                 manifester_directory = (
-                    Path(os.environ["MANIFESTER_DIRECTORY"])
+                    Path(os.environ["MANIFESTER_DIRECTORY"]).resolve()
                     if "MANIFESTER_DIRECTORY" in os.environ
                     else Path()
                 )

manifester/helpers.py

@@ -347,7 +347,7 @@ def login(self, **kwargs):
 
     def logout(self):
         """Revoke Vault auth token and remove it from .env file."""
-        # Teardown - Setting dymmy token in env file
+        # Teardown - Setting dummy token in env file
         _envdata = re.sub(
             ".*VAULT_TOKEN_FOR_DYNACONF=.*", "# VAULT_TOKEN_FOR_DYNACONF=myroot", self.envdata
         )

manifester/manifester.py

@@ -258,6 +258,7 @@ def process_subscription_pools(self, subscription_pools, subscription_data):
         Identifies pools that match the subscription names and quantities defined in settings, then
         attempts to add the specified quantity of each subscription to the allocation.
         """
+        breakpoint()
         SUCCESS_CODE = 200
         logger.debug(f"Finding a matching pool for {subscription_data['name']}.")
         matching = [

manifester/settings.py

@@ -2,7 +2,7 @@
 import os
 from pathlib import Path
 
-from dynaconf import LazySettings, Validator
+from dynaconf import Dynaconf, Validator
 
 settings_file = "manifester_settings.yaml"
 MANIFESTER_DIRECTORY = Path()
@@ -18,10 +18,10 @@
     Validator("simple_content_access", default="enabled"),
     Validator("username_prefix", len_min=3),
 ]
-settings = LazySettings(
+settings = Dynaconf(
     settings_file=str(settings_path.absolute()),
     ENVVAR_PREFIX_FOR_DYNACONF="MANIFESTER",
     load_dotenv=True,
     validators=validators,
 )
-settings.validators.validate()
+# settings.validators.validate()