Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Default Env to standardize TLD and Port #9

Open
corysabol opened this issue Jul 6, 2022 · 1 comment
Open

Change Default Env to standardize TLD and Port #9

corysabol opened this issue Jul 6, 2022 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@corysabol
Copy link
Contributor

The default env needs to have the api host changed to https://api.cors.test:8443 in order for the labs to work as we are standardizing on .test and 8443.

@corysabol corysabol added bug Something isn't working enhancement New feature or request labels Jul 6, 2022
@corysabol corysabol self-assigned this Jul 6, 2022
@corysabol
Copy link
Contributor Author

const apiHost = process.env.CORS_API_HOST || 'api.cors.dem';

We can change this logic on this line. But also we should feed in a default set of env vars anyhow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant