Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem when Pretrainig the model with past_feat_dynamic_real #170

Open
bkoyuncu opened this issue Jan 8, 2025 Discussed in #169 · 2 comments
Open

Problem when Pretrainig the model with past_feat_dynamic_real #170

bkoyuncu opened this issue Jan 8, 2025 Discussed in #169 · 2 comments

Comments

@bkoyuncu
Copy link

bkoyuncu commented Jan 8, 2025

Discussed in #169

Originally posted by bkoyuncu January 8, 2025
Hello,

I have created my data with past_feat_dynamic_real, however, I believe the current implementation in pretrain.py does not include them in training as:

+ SelectFields(fields=list(self.seq_fields))

where self.seq_fields are defined as

seq_fields: tuple[str, ...] = (
"target",
"observed_mask",
"time_id",
"variate_id",
"prediction_mask",
"patch_size",

I believe past_feat_dynamic_real are not being output in the end of processing the input data.

Is this an expected behaviour? How can I make sure past_feat_dynamic_real are used in training?

@bkoyuncu
Copy link
Author

bkoyuncu commented Jan 8, 2025

I am thinking if past_feat_dynamic_real needs to be truncated with other inputs as these are known context features, which should not be masked at all.

+ MaskedPrediction(
min_mask_ratio=self.hparams.min_mask_ratio,
max_mask_ratio=self.hparams.max_mask_ratio,
target_field="target",
truncate_fields=("variate_id", "time_id", "observed_mask"),
optional_truncate_fields=("past_feat_dynamic_real",),
prediction_mask_field="prediction_mask",
expected_ndim=3,

@liuxu77
Copy link
Contributor

liuxu77 commented Jan 10, 2025

Hi @bkoyuncu, I think past_feat_dynamic_real should be involved in the "target", and at the same time, their prediction_mask are all set to False.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants