feat: improve hover accuracy

chore: update changelog to describe better what 0.0.1 will include

Author: LuckyLuuk12

CHANGELOG.md

@@ -4,8 +4,76 @@ All notable changes to the "sac-language-support" extension will be documented i
 
 ## [0.0.1]: [release date]
 
-- Added a minimal SaC language server that publishes compiler diagnostics.
-- Added configurable diagnostics modes (`onSave`, `onType`, `manual`).
-- Added compiler resolution strategy with `system`, `stable`, and `develop` channels.
-- Added machine-readable diagnostics parsing support via configurable messaging arguments.
-- Added bundled compiler folder conventions under `vendor/sac2c/`.
+### Language + Editor Support
+
+- Added SaC language registration for `.sac` files.
+- Added language configuration for editor behaviors (comments/brackets/word boundaries).
+- Added SaC TextMate grammar + injection support for SaC-aware highlighting inside C scopes.
+- Added built-in SaC snippets.
+- Added SaC file icon contribution and icon theme mapping.
+- Added multiple bundled SaC color themes (`Default`, `Warm`, `Cool`, `Vibrant`).
+
+### Language Server (LSP)
+
+- Added SaC language server activation and lifecycle wiring from the extension host.
+- Added diagnostics publication to Problems panel + inline squiggles.
+- Added hover provider for:
+	- builtins + stdlib docs from `docs/builtins` and `docs/stdlib`
+	- compiler-index-backed symbols when available
+	- source-defined function docs/signatures fallback
+- Added go-to-definition provider using compiler navigation index with source/stdlib fallbacks.
+- Added safe server error handling (`runSafely`) so failures are logged instead of crashing server process.
+
+### Diagnostics Pipeline
+
+- Added diagnostics execution modes: `onSave`, `onType` (debounced), `manual`.
+- Added diagnostics presentation modes: `expanded`, `smart`, `hybrid`.
+- Added best-effort parser/grouping pipeline for `sac2c` output.
+- Added related information + stack/context rendering controls:
+	- `sac.diagnostics.includeRelatedInformation`
+	- `sac.diagnostics.includeStackInMessage`
+	- `sac.diagnostics.maxStackFrames`
+- Added workspace-wide diagnostics scan controls:
+	- `sac.diagnostics.workspaceScan.enabled`
+	- `sac.diagnostics.workspaceScan.onInitialize`
+	- `sac.diagnostics.workspaceScan.onConfigurationChange`
+	- `sac.diagnostics.workspaceScan.excludeDirectories`
+
+**Compiler prerequisite (current fork status):**
+
+- Error-column diagnostics improvements rely on sac2c branch: <https://gitlab.sac-home.org/LuckyLuuk/sac2c/-/tree/luukk/error-end-column>
+- Related upstream MR draft: <https://gitlab.sac-home.org/sac-group/sac2c/-/merge_requests/633>
+
+### Compiler Resolution + Execution
+
+- Added compiler resolution strategy with channels: `system`, `stable`, `develop`.
+- Added explicit compiler path override via `sac.compiler.path`.
+- Added fallback behavior to system compiler when bundled channel binary is missing.
+- Added backend execution modes:
+	- `local`
+	- `wsl` (Windows host)
+	- `docker`
+- Added configurable extra compiler args and deterministic messaging args:
+	- `sac.compiler.extraArgs`
+	- `sac.compiler.messaging.enabled`
+	- `sac.compiler.messaging.args`
+
+### Navigation + Hover Docs Infrastructure
+
+- Added markdown documentation lookup + formatting pipeline for hover content.
+- Added heading/section parsing helpers for richer hover rendering.
+- Added builtin family doc resolution (for example `_add_SxS_` -> `_add_.md`).
+- Added hover/definition runtime tracing controls via `sac.compiler.trace` and debug logging hooks.
+
+**Compiler prerequisite (current fork status):**
+
+- Hover/navigation output-phase support currently depends on fork branch: <https://gitlab.sac-home.org/LuckyLuuk/sac2c/-/commits/luukk/vscode-extension-output-phase>
+
+### Repository + Packaging Foundations
+
+- Added diagnostics architecture docs (`docs/diagnostics-pipeline.md`, `docs/editor-agnostic-diagnostics.md`).
+- Added extension packaging optimization:
+	- esbuild bundle pipeline for extension + server outputs
+	- prepublish bundle hook before `vsce package`
+	- lean `.vscodeignore` rules for smaller VSIX artifacts
+- Added initial GitHub workflow foundation for nightly/stable VSIX release automation.

src/sac2c/hover/index.ts

@@ -139,7 +139,7 @@ export function lookupHoverTarget(lineText: string, column: number): HoverMatch
     return stdlib;
   }
 
-  return lookupAnyCallIdentifier(lineText, column);
+  return null;
 }
 
 /**

src/sac2c/parser/navigation/sourceDocs.ts

@@ -426,7 +426,13 @@ export function findFunctionDefinitionLineByName(sourceText: string, functionNam
 
   for (let lineIndex = 0; lineIndex < lines.length; lineIndex += 1) {
     const lineText = lines[lineIndex];
-    if (pattern.test(lineText)) {
+    const trimmed = lineText.trim();
+    if (trimmed.startsWith("//") || trimmed.startsWith("/*") || trimmed.startsWith("*")) {
+      continue;
+    }
+
+    const nextNonEmptyLine = lines.slice(lineIndex + 1).find((nextLine) => nextLine.trim().length > 0);
+    if (pattern.test(lineText) && isPotentialFunctionDefinitionLine(lineText, nextNonEmptyLine)) {
       return lineIndex;
     }
   }

src/server/hover-info/hover.ts

@@ -162,15 +162,18 @@ export async function provideHover(
     const docComment = readDefinitionDocComment(compilerHover.definitionPath, compilerHover.definitionLine);
     const sourceSignature = readDefinitionSignature(compilerHover.definitionPath, compilerHover.definitionLine);
     const preferredSignature = pickPreferredSignature(compilerHover.signature, sourceSignature);
+    const isUserSymbol = compilerHover.symbolProvenance === "user";
     let docsMarkdown: string | null = null;
     const docsTargets: HoverTarget[] = [];
-    if (lexedMatch) {
+
+    // For user symbols, docs must come from resolved definition comments only.
+    if (!isUserSymbol && lexedMatch) {
       docsTargets.push(lexedMatch.target);
     }
     if (compilerTarget) {
       docsTargets.push(compilerTarget);
     }
-    if (compilerHover.symbolProvenance !== "user") {
+    if (!isUserSymbol) {
       const symbolNameTarget = hoverTargetFromSymbolName(compilerHover.symbolName);
       if (symbolNameTarget) {
         docsTargets.push(symbolNameTarget);
@@ -184,7 +187,7 @@ export async function provideHover(
       }
     }
 
-    const preferStaticDocs = compilerHover.symbolProvenance !== "user";
+    const preferStaticDocs = !isUserSymbol;
     const docBody = preferStaticDocs ? (docsMarkdown ?? docComment) : (docComment ?? docsMarkdown);
     const metadata = [
       `Kind: \`${compilerHover.symbolKind}\``,
@@ -199,6 +202,14 @@ export async function provideHover(
 
     const hasUsefulDocs = Boolean(docBody?.trim());
     const hasUsefulSignature = Boolean(preferredSignature?.trim());
+
+    if (isUserSymbol) {
+      return {
+        contents: createMarkdownContent(markdown),
+        range: compilerHover.range,
+      };
+    }
+
     if (!hasUsefulDocs && !hasUsefulSignature) {
       logHoverDebug("hover-compiler-low-confidence-fallback", {
         symbolName: compilerHover.symbolName,
@@ -248,19 +259,18 @@ export async function provideHover(
         const filePath = fileURLToPath(document.uri);
         const docComment = readDefinitionDocComment(filePath, definitionLine);
         const signature = readDefinitionSignature(filePath, definitionLine);
-        if (!docComment && !signature) {
-          return null;
+        if (docComment || signature) {
+          logHoverDebug("hover-source-call-hit", {
+            name: sourceCall.name,
+            definitionLine,
+            hasDocComment: Boolean(docComment),
+          }, debugLog);
+
+          return {
+            contents: createMarkdownContent(formatHoverDocumentationMarkdown(docComment ?? "", { signature })),
+            range: createLineRange(position.line, sourceCall.startCharacter, sourceCall.endCharacter),
+          };
         }
-        logHoverDebug("hover-source-call-hit", {
-          name: sourceCall.name,
-          definitionLine,
-          hasDocComment: Boolean(docComment),
-        }, debugLog);
-
-        return {
-          contents: createMarkdownContent(formatHoverDocumentationMarkdown(docComment ?? "", { signature })),
-          range: createLineRange(position.line, sourceCall.startCharacter, sourceCall.endCharacter),
-        };
       }
     }
   }

src/server/navigation/compilerCommand.ts

@@ -67,7 +67,7 @@ export function buildNavArgs(
     "-v0",
     "-navjson",
     "-nav-mode",
-    "document-symbols",
+    mode,
     "-nav-file",
     documentFsPath,
     "-nav-line",