Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MERA and QuantumConvolutionalLayer to consider unmeasured qubits only. #10

Open
SaashaJoshi opened this issue Nov 23, 2023 · 0 comments
Labels
bug Something isn't working slow-progress Developing slowly

Comments

@SaashaJoshi
Copy link
Owner

Conv layer or the MERA structure still doesn't take into consideration only the unmeasured qubits. If applied more than once, a conv layer is built on all the qubits and not just the unmeasured ones. This needs to be corrected.

Originally posted by @SaashaJoshi in #6 (comment)

@SaashaJoshi SaashaJoshi added this to the v0.1.0 milestone Nov 27, 2023
@SaashaJoshi SaashaJoshi added the bug Something isn't working label Nov 29, 2023
SaashaJoshi added a commit that referenced this issue Dec 8, 2023
…obably should be fixed while working on #10), and duplicate-code in ttn_circuit and mera_circuit fixtures. this duplicate code can eb ignored since it will be quite difficult to reuse the fixture in either of the files.
SaashaJoshi added a commit that referenced this issue Dec 8, 2023
* initial commit

* remove extensive branching in mera. this closes #17. minor changes to ttn.

* minor syntax change

* correct number of params for simple parameterization

* add more tests cases for ttn. add more tests for mera

* disable some pylint errors, for example, too-many-args (which  most probably should be fixed while working on #10), and duplicate-code in ttn_circuit and mera_circuit fixtures. this duplicate code can eb ignored since it will be quite difficult to reuse the fixture in either of the files.

* add new test for num_qubits = 5. this brings the tests to 100 percent coverage

* add two more tests for complex general and real general for 5 qubits
@SaashaJoshi SaashaJoshi modified the milestones: v0.0.1, v0.0.2 Dec 9, 2023
@SaashaJoshi SaashaJoshi added the slow-progress Developing slowly label Apr 24, 2024
@SaashaJoshi SaashaJoshi removed this from the v0.0.1a milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working slow-progress Developing slowly
Projects
None yet
Development

No branches or pull requests

1 participant