Skip to content

src/reader.rs: all four public functions (get_order_count/keys, get_withdrawal_count/keys) have zero test coverage #521

Description

@abayomicornelius

Problem

reader::get_order_count, get_order_keys, get_withdrawal_count, and get_withdrawal_keys (src/reader.rs:50-248) are async functions that build a simulateTransaction JSON-RPC payload and parse the response. None of the four functions is called by any test, and none are called from keeper_loop.rs either, which reimplements equivalent logic inline via its own private get_pending_keys. This module appears to be dead code.

Why it matters

Whether truly dead or intended to be wired in later, it currently ships in the binary with a public API surface and request-building logic that has never been executed even once by a test.

Suggested fix

Either delete src/reader.rs if confirmed dead code, or add wiremock-based tests for each of the four functions covering the success path and each error branch.

Metadata

Metadata

Assignees

Labels

GrantFox OSSIssue tracked in GrantFox OSSMaybe RewardedIssue may be eligible for a GrantFox rewardOfficial Campaign | FWC26Campaign: Official Campaign | FWC26Stellar WaveIssues in the Stellar wave programtestingTest coverage

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions