deposit_handler: load_market_props raises DepositNotFound for an unregistered market during create_deposit

[abayomicornelius]

Problem

deposit_handler::load_market_props panics with Error::DepositNotFound when market keys are absent from data_store. This helper is called from create_deposit BEFORE any deposit exists — so a caller passing an unregistered/malformed market address gets DepositNotFound, which semantically means "no such deposit" (and is reused elsewhere for exactly that meaning). withdrawal_handler's equivalent correctly uses InvalidMarket for the same condition.

Why it matters

Any client, indexer, or wallet that branches on the handler's typed error code to distinguish "this deposit id doesn't exist" from "you passed a bad/unconfigured market" will misclassify the latter as the former when creating a deposit, producing a confusing error-handling path.

Suggested fix

Give deposit_handler its own InvalidMarket error variant (as withdrawal_handler already has) and use it in load_market_props, reserving DepositNotFound for lookups of an existing deposit key.

[sir-emmy1]

@sir-emmy1 has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

I would like to work on this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @sir-emmy1 to this issue.

[DavidAkere204]

@DavidAkere204 has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

I would like to work on this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @DavidAkere204 to this issue.

[AJ0070]

@AJ0070 has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

Could you please assign this to me? I would like to work on this issue.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @AJ0070 to this issue.

[leojay-net]

@leojay-net has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

I would like to work on this issue.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @leojay-net to this issue.

[drips-wave]

Congratulations, @leojay-net! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on July 30, 2026.

🧑‍💻 @leojay-net: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊