Skip to content

yunhee-week6-hwdone#14

Open
yunheeec wants to merge 1 commit intoyunhee-week6from
yunhee-week6-hw
Open

yunhee-week6-hwdone#14
yunheeec wants to merge 1 commit intoyunhee-week6from
yunhee-week6-hw

Conversation

@yunheeec
Copy link

💎 과제 구현 설명

과제를 위해 사용했던 함수, 수정한 파일 등 구현 내용에 대한 간단한 설명을 작성해 주세요.

🏁 PR 체크리스트

  • [ㅇ] 코드가 오류 없이 정상적으로 실행되나요?
  • [ㅇ] 커밋 메시지 컨벤션(템플릿 활용)을 준수했나요?
  • [ㅇ] 과제 마감기한을 준수했나요?

🖼️ Screenshot / Video

vote history
vote page

🙌 Issue

과제 수행 중 어려웠던 부분이나 궁금했던 점을 자유롭게 작성해 주세요.

Copy link

@unknownburphy unknownburphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전체적으로 아주 잘 구현하신 것 같습니다. 무서운 재능이시군요... LGTM!

className={`object-cover w-full h-full border-[3px] border-[#FF6841] rounded-xl
### FILL ME ###
className={`object-cover w-full h-full border-[3px] rounded-xl
${img.value === 1 ? "border-[#ff4141]" : "border-[#3457e4]"}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

삼항연산자를 이용해 잘 처리했네요 굿!

Comment on lines +70 to +81
const handleThumbsUpHover = () => {
setThumbsUpImage(require("../assets/images/thumbs-up-click.png"));
};
const handleThumbsUpLeave = () => {
setThumbsUpImage(require("../assets/images/thumbs-up-icon.png"));
};
const handleThumbsDownHover = () => {
setThumbsDownImage(require("../assets/images/thumbs-down-click.png"));
};
const handleThumbsDownLeave = () => {
setThumbsDownImage(require("../assets/images/thumbs-down-icon.png"));
};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

함수명도 아주 잘 지은 것 같습니다.

Copy link

@minseo25 minseo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전체적으로 깔끔하게 코드 잘 짜신 것 같아요~!

// ### thumbsUpImage Event ###
onMouseOver={handleThumbsUpHover}
onMouseOut={handleThumbsUpLeave}
onClick={() => vote(1)}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저는 투표 시 vote(1); 후에 getImage(); 호출을 통해 다음 투표할 이미지를 불러왔는데
개인 구현 차이 같아서 참고만 하셔도 좋을 것 같아요~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants