Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove support for $SNOWGLOBES variable to use custom SNOwGLoBES directory #371

Open
JostMigenda opened this issue Dec 11, 2024 · 1 comment
Milestone

Comments

@JostMigenda
Copy link
Member

as we're using snowglobes_data, we can drop the support of $SNOWGLOBES variable. If a user needs to use a custom snowglobes, they can use pip install $SNOWGLOBES/snowglobes_data to use their package in snewpy.

Originally posted by @Sheshuk in #370 (comment)

@JostMigenda
Copy link
Member Author

Before we had snowglobes_data available as a separate package, setting the SNOwGLoBES directory via an environment variable was useful; now that we do have a separate package, keeping the environment variable around to override the installed package can be confusing. As @Sheshuk highlighted in #370, it can even lead to bugs if people update to a newer version of snewpy but forget to update the version of SNOwGLoBES.

Since I don’t see a significant advantage of using the environment variable to point to a custom version of SNOwGLoBES over pip-installing that same custom version, I’d be in favour of removing support for the environment variable.

@JostMigenda JostMigenda added this to the v2.0 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant