Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile misses dependency for bdbwrap #50

Open
ygrek opened this issue Aug 1, 2017 · 2 comments
Open

Makefile misses dependency for bdbwrap #50

ygrek opened this issue Aug 1, 2017 · 2 comments
Labels
bug Something isn't working major

Comments

@ygrek
Copy link
Member

ygrek commented Aug 1, 2017

Original report by Daniel Kahn Gillmor (Bitbucket: dkgdkg, GitHub: dkgdkg).


The Makefile does not state all the necessary dependencies:

$ make dep && make bdbclean clean && make bdbwrap.cmi
ocamldep -pp camlp4o  *.mli *.ml > .depend
cd bdb && make clean
make[1]: Entering directory '/home/dkg/src/sks/sks.dkgbb/bdb'
rm -f *.cm*
rm -f *.a *.o
rm -f bdb.ml
rm -f ocextr
make[1]: Leaving directory '/home/dkg/src/sks/sks.dkgbb/bdb'
rm -f *.cm[iox]
rm -f *.annot
rm -f *.opt
rm -f *.bc
rm -rf spider sksclient
rm -f sks sks_add_mail sks.8.gz sks.bc sks_add_mail.bc sks.8.gz
rm -f *.o
rm -f prepared
rm -f sks.8.gz
ocamlfind ocamlc -package cryptokit,unix,str,bigarray,num -I lib -I bdb   -ccopt -Lbdb -dtypes -warn-error A -linkpkg -g bdb.cma -c bdbwrap.mli
File "bdbwrap.mli", line 4, characters 13-22:
Error: Unbound module Bdb
Makefile:357: recipe for target 'bdbwrap.cmi' failed
make: *** [bdbwrap.cmi] Error 2
2 dkg@alice:~/src/sks/sks.dkgbb$ 
@ygrek
Copy link
Member Author

ygrek commented Aug 2, 2017

Original comment by Daniel Kahn Gillmor (Bitbucket: dkgdkg, GitHub: dkgdkg).


see pull request #57

@ygrek
Copy link
Member Author

ygrek commented Aug 6, 2018

Original comment by ygrek (Bitbucket: f_x, ).


Why specifically bdbwrap? There are a lot of things missing direct dependency on bdb (see by adding -I bdb to ocamldep invocation in Makefile). The point is that all ml files in root directory depend on bdb "sublibrary" being built beforehand and Makefile takes care of building it before building other targets.

@ygrek ygrek added major bug Something isn't working labels May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working major
Projects
None yet
Development

No branches or pull requests

1 participant