Restructured 200-level test cases into unified describe block with inline token setup

Author: Pikalot

test/api/AuditLog.js

@@ -6,21 +6,13 @@ const AuditLog = require('../../api/main_endpoints/models/AuditLog.js');
 const chai = require('chai');
 
 const chaiHttp = require('chai-http');
-const sinon = require('sinon');
 const {
-  OK,
-  BAD_REQUEST,
   UNAUTHORIZED,
-  FORBIDDEN,
-  NOT_FOUND,
-  CONFLICT,
-  SERVER_ERROR,
 } = require('../../api/util/constants.js').STATUS_CODES;
 const SceApiTester = require('../util/tools/SceApiTester.js');
 
 let app = null;
 let test = null;
-let sandbox = sinon.createSandbox();
 const expect = chai.expect;
 const tools = require('../util/tools/tools.js');
 const {
@@ -36,7 +28,6 @@ const {
   initializeDiscordAPIMock
 } = require('../util/mocks/DiscordApiFunction.js');
 const { MEMBERSHIP_STATE } = require('../../api/util/constants.js');
-const { getMemberExpirationDate } = require('../../api/main_endpoints/util/userHelpers.js');
 const AuditLogActions = require('../../api/main_endpoints/util/auditLogActions.js');
 
 chai.should();
@@ -106,10 +97,8 @@ describe('AuditLog', () => {
       expect(result).to.have.status(UNAUTHORIZED);
     });
 
-    describe('When token and access level is valid - status code 200', () => {
-      beforeEach(() => {
-        setTokenStatus(true, { accessLevel: MEMBERSHIP_STATE.OFFICER });
-      });
+    it('Should return at most 50 records when query is an empty string and access level is valid', async () => {
+      setTokenStatus(true, { accessLevel: MEMBERSHIP_STATE.OFFICER});
 
       before(async () => {
         const newUser = new User({
@@ -139,32 +128,31 @@ describe('AuditLog', () => {
           });
         }
       });
+      const result = await test.sendGetRequestWithToken(token, url);
+      expect(result.body.items).that.is.an('array');
+      expect(result.body.items.length).at.most(50);
+    });
 
-      it('Should return at most 50 records when query is empty', async () => {
-        const result = await test.sendGetRequestWithToken(token, url);
-        expect(result.body.items).that.is.an('array');
-        expect(result.body.items.length).at.most(50);
-      });
-
-      it('Should return the testUser when query is "[email protected]"', async () => {
-        const search = '[email protected]';
-        const fullUrl = `/api/AuditLog/getAuditLogs?search=${encodeURIComponent(search)}`;
-        const result = await test.sendGetRequestWithToken(token, fullUrl);
-        expect(result.body.items).that.is.an('array').to.have.lengthOf(1);
-        expect(result.body.items[0].userId.email).to.eql('[email protected]');
-      });
+    it('Should return the testUser when query is "[email protected]" and access level is OFFICER', async () => {
+      setTokenStatus(true, { accessLevel: MEMBERSHIP_STATE.OFFICER});
+      const search = '[email protected]';
+      const fullUrl = `/api/AuditLog/getAuditLogs?search=${encodeURIComponent(search)}`;
+      const result = await test.sendGetRequestWithToken(token, fullUrl);
+      expect(result.body.items).that.is.an('array').to.have.lengthOf(1);
+      expect(result.body.items[0].userId.email).to.eql('[email protected]');
+    });
 
-      it('Should return an empty array when the query matches no record: "[email protected]"', async () => {
-        const search = '[email protected]';
-        const fullUrl = `/api/AuditLog/getAuditLogs?search=${encodeURIComponent(search)}`;
-        const result = await test.sendGetRequestWithToken(token, fullUrl);
-        expect(result.body.items).that.is.an('array').that.is.empty;
-      });
+    it('Should return an empty array when the query matches no record: "[email protected]" and access level is ADMIN', async () => {
+      setTokenStatus(true, { accessLevel: MEMBERSHIP_STATE.ADMIN});
+      const search = '[email protected]';
+      const fullUrl = `/api/AuditLog/getAuditLogs?search=${encodeURIComponent(search)}`;
+      const result = await test.sendGetRequestWithToken(token, fullUrl);
+      expect(result.body.items).that.is.an('array').that.is.empty;
+    });
 
-      after(async () => {
-        await User.deleteMany({});
-        await AuditLog.deleteMany({});
-      });
+    after(async () => {
+      await User.deleteMany({});
+      await AuditLog.deleteMany({});
     });
   });
 });