Skip to content

Prefer INSERT INTO TABLE to APPEND TO #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lucasborin opened this issue Jun 18, 2021 · 2 comments
Closed

Prefer INSERT INTO TABLE to APPEND TO #415

lucasborin opened this issue Jun 18, 2021 · 2 comments
Labels
new check New check

Comments

@lucasborin
Copy link
Member

Prefer INSERT INTO TABLE to APPEND TO

INSERT VALUE #( ... ) INTO TABLE itab.
INSERT INTO TABLE works with all table and key types, thus making it easier for you to refactor the table's type and key definitions if your performance requirements change.

Use APPEND TO only if you use a STANDARD table in an array-like fashion, if you want to stress that the added entry shall be the last row.

https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-insert-into-table-to-append-to
@lucasborin lucasborin added the new check New check label Jun 18, 2021
@lucasborin lucasborin self-assigned this Jun 18, 2021
@lucasborin lucasborin removed their assignment Jun 25, 2021
@00500500 00500500 mentioned this issue Nov 11, 2024
Merged
bjoern-jueliger-sap pushed a commit that referenced this issue Nov 29, 2024
@00500500
add new check for 'Prefer INSERT INTO TABLE to APPEND TO' (#623)
a3fa5fc 
* added check for Prefer INSERT INTO TABLE to APPEND

#415

* change documentation path

* added docs

* Delete prefer-insert-into-to-append.md

* add docs

* Update check_documentation.md

* not emit findings for append ... to ... sorted by

* Update src/y_check_prefer_insert_into.clas.abap
@00500500
Copy link
Contributor

00500500 commented Dec 2, 2024

@bjoern-jueliger-sap sorry for the tag, but I think we can close this issue now, right?

@bjoern-jueliger-sap
Copy link
Member

@00500500 Yep, closing this.
Tip: If you write "Closes #415" in the first line of the pull request (instead of just "#415" as you did in #623), merging the pull request automatically closes the referenced issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new check New check
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lucasborin @bjoern-jueliger-sap @00500500