replace select with conditional_select

Author: xuganyu96

src/uint/boxed/cmp.rs

@@ -11,23 +11,6 @@ use subtle::{
 };
 
 impl BoxedUint {
-    /// Return `b` if `c` is truthy, otherwise return `a`.
-    #[inline]
-    pub(crate) fn select(a: &Self, b: &Self, c: ConstChoice) -> Self {
-        debug_assert_eq!(a.limbs.len(), b.limbs.len());
-        let mut limbs = vec![Limb::ZERO; a.limbs.len()];
-
-        let mut i = 0;
-        while i < limbs.len() {
-            limbs[i] = Limb::select(a.limbs[i], b.limbs[i], c);
-            i += 1;
-        }
-
-        Self {
-            limbs: limbs.into(),
-        }
-    }
-
     /// Returns the truthy value if `self >= rhs` and the falsy value otherwise.
     #[inline]
     pub(crate) fn gt(lhs: &Self, rhs: &Self) -> ConstChoice {

src/uint/boxed/sqrt.rs

@@ -48,7 +48,7 @@ impl BoxedUint {
         // At this point `x_prev == x_{n}` and `x == x_{n+1}`
         // where `n == i - 1 == LOG2_BITS + 1 == floor(log2(BITS)) + 1`.
         // Thus, according to Hast, `sqrt(self) = min(x_n, x_{n+1})`.
-        Self::select(&x_prev, &x, BoxedUint::gt(&x_prev, &x))
+        Self::conditional_select(&x_prev, &x, Self::gt(&x_prev, &x).into())
     }
 
     /// Computes √(`self`)