Respect Windows output device selection

[JasonWei512]

I am using rodio to play audio on Windows 11. When I change the output device on Windows, the audio continues to play on the old device.

There is a similar issue for macOS (#327). But that is fixed in RustAudio/cpal#648.

Is it the right place to open an issue? Or should I open it in cpal's repository?

[dvdsk]

Thanks for adding the issue upstream btw! I'll keep this issue open to keep track of it.

related issue: RustAudio/cpal#740

[philpax]

I've PR'd RustAudio/cpal#1027, which is an updated version of RustAudio/cpal#754. This is not a complete fix, as it will only work on >=Windows 8, but it should be sufficient to unblock most use cases.

To use it with rodio, first depend on a version of rodio that's compatible with cpal's HEAD; I've prepared a fork/PR for this. Once you've done this, patch cpal in your dependency tree to use my PR's version:

[dependencies]
rodio = { git = "https://github.com/philpax/rodio.git", branch = "latest-cpal-fixes" }

[patch.'https://github.com/RustAudio/cpal']
cpal = { git = "https://github.com/philpax/cpal.git", branch = "audio-device-fix-updated" }

(I wanted to restrict it to just a cpal patch, but there was a minor change in the cpal API surface that required changes in rodio. My rodio fork will not be necessary once they sync up again.)

After you make any necessary API fixes for rodio (I didn't have to make any), you should now be able to change your default device around to your heart's content. For example, here's the changes I made for my music player.

[PetrGlad]

I am always in favor of making it better even if solution is not perfect. But if you decide to use the patched version as dependency, it makes sense to use a specific version (commit hash), not a branch.
This would help with repeatable builds and help reviewing which changes rodio gets.

[philpax]

Aye, that's what I would normally do, but the branches are the ones used by the PRs; my thinking is that it'll be easier to review if they match up with what you can see in the PRs (of course, with the caveat that users will need to cargo update to keep up with the PRs).