Skip to content

Commit 8ab58f6

Browse files
committed
gpu: host1x: Do not setup DMA for virtual devices
The host1x devices are virtual compound devices and do not perform DMA accesses themselves, so they do not need to be set up for DMA. Ideally we would also not need to set up DMA masks for the virtual devices, but we currently still need those for legacy support on old hardware. Tested-by: Jon Hunter <[email protected]> Acked-by: Jon Hunter <[email protected]> Signed-off-by: Thierry Reding <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent fd7726e commit 8ab58f6

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

drivers/gpu/host1x/bus.c

-8
Original file line numberDiff line numberDiff line change
@@ -351,11 +351,6 @@ static int host1x_device_uevent(const struct device *dev,
351351
return 0;
352352
}
353353

354-
static int host1x_dma_configure(struct device *dev)
355-
{
356-
return of_dma_configure(dev, dev->of_node, true);
357-
}
358-
359354
static const struct dev_pm_ops host1x_device_pm_ops = {
360355
.suspend = pm_generic_suspend,
361356
.resume = pm_generic_resume,
@@ -369,7 +364,6 @@ const struct bus_type host1x_bus_type = {
369364
.name = "host1x",
370365
.match = host1x_device_match,
371366
.uevent = host1x_device_uevent,
372-
.dma_configure = host1x_dma_configure,
373367
.pm = &host1x_device_pm_ops,
374368
};
375369

@@ -458,8 +452,6 @@ static int host1x_device_add(struct host1x *host1x,
458452
device->dev.bus = &host1x_bus_type;
459453
device->dev.parent = host1x->dev;
460454

461-
of_dma_configure(&device->dev, host1x->dev->of_node, true);
462-
463455
device->dev.dma_parms = &device->dma_parms;
464456
dma_set_max_seg_size(&device->dev, UINT_MAX);
465457

0 commit comments

Comments
 (0)