Skip to content

Comments

[Refactor/prod settings] - prod 환경 설정#101

Merged
ekgns33 merged 3 commits intomainfrom
refactor/prod-settings
Jun 18, 2025
Merged

[Refactor/prod settings] - prod 환경 설정#101
ekgns33 merged 3 commits intomainfrom
refactor/prod-settings

Conversation

@ekgns33
Copy link
Contributor

@ekgns33 ekgns33 commented Jun 18, 2025

작업 내역

  • Prod에서 Actuator 엔드포인트를 개방했습니다.
  • Bean정보는 나가지 않도록 application.yml 에서 설정했습니다. f8ee820 , 4f78333
  • Prod에서 유저 API는 권한을 확인하도록 추가했습니다.

Summary by CodeRabbit

  • New Features

    • Role-based access control added for user-related API endpoints, allowing access only to users with "USER" or "ADMIN" roles.
    • The /actuator/** endpoints are now publicly accessible.
  • Chores

    • Enhanced security by explicitly excluding sensitive management endpoints (env, heapdump, threaddump) from web exposure.

@ekgns33 ekgns33 requested a review from jeeheaG June 18, 2025 03:23
@ekgns33 ekgns33 self-assigned this Jun 18, 2025
@coderabbitai
Copy link

coderabbitai bot commented Jun 18, 2025

Walkthrough

Role-based access control was added for the /api/v1/users/** endpoint, restricting it to users with "USER" or "ADMIN" roles in production and test profiles. The /actuator/** endpoint was made publicly accessible. Additionally, the application configuration now explicitly excludes certain management endpoints from web exposure.

Changes

File(s) Change Summary
.../config/SecurityConfig.java Updated security settings: added role-based access for /api/v1/users/**, made /actuator/** public, reordered matchers.
.../resources/application.yml Added exclude list for management endpoints: env, heapdump, threaddump are now not exposed.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SecurityConfig
    participant Application

    User->>SecurityConfig: Request /api/v1/users/**
    SecurityConfig->>User: Check roles ("USER" or "ADMIN")
    alt Authorized
        SecurityConfig->>Application: Allow access
    else Not authorized
        SecurityConfig->>User: Deny access
    end

    User->>SecurityConfig: Request /actuator/**
    SecurityConfig->>Application: Permit all access
Loading

Poem

In the warren of code, new rules now appear,
Users and admins, your access is clear!
Actuators open, but some doors are shut—
Heapdumps and env, you’ll find in a rut.
With roles and with rhyme,
The system’s in line—
A hop and a skip, security’s prime! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 444c74c and 4f78333.

📒 Files selected for processing (2)
  • src/main/java/org/runimo/runimo/config/SecurityConfig.java (1 hunks)
  • src/main/resources/application.yml (1 hunks)

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sonarqubecloud
Copy link

Copy link
Contributor

@jeeheaG jeeheaG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다. 고생많으셨습니다!

@ekgns33 ekgns33 merged commit 5ffc95b into main Jun 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants