Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 45c42ec

Browse files
MichalStrehovskyRuihan-Yin
authored andcommittedMay 30, 2024
Remove IgnoreExitCode from lld version check (dotnet#102278)
Subset of dotnet#102000.
1 parent 631b785 commit 45c42ec

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed
 

‎src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets

+2-3
Original file line numberDiff line numberDiff line change
@@ -285,12 +285,11 @@ The .NET Foundation licenses this file to you under the MIT license.
285285
<Error Condition="'$(_WhereLinker)' != '0' and '$(CppCompilerAndLinkerAlternative)' == '' and '$(_IsApplePlatform)' != 'true'"
286286
Text="Requested linker ('$(CppLinker)') not found in PATH." />
287287

288-
<Exec Command="&quot;$(CppLinker)&quot; -fuse-ld=lld -Wl,--version" Condition="'$(LinkerFlavor)' == 'lld'" IgnoreExitCode="true" StandardOutputImportance="Low" ConsoleToMSBuild="true">
289-
<Output TaskParameter="ExitCode" PropertyName="_LinkerVersionStringExitCode" />
288+
<Exec Command="&quot;$(CppLinker)&quot; -fuse-ld=lld -Wl,--version" Condition="'$(LinkerFlavor)' == 'lld'" StandardOutputImportance="Low" ConsoleToMSBuild="true">
290289
<Output TaskParameter="ConsoleOutput" PropertyName="_LinkerVersionString" />
291290
</Exec>
292291

293-
<PropertyGroup Condition="'$(_LinkerVersionStringExitCode)' == '0' and '$(_LinkerVersionString)' != ''">
292+
<PropertyGroup Condition="'$(_LinkerVersionString)' != ''">
294293
<_LinkerVersion>$([System.Text.RegularExpressions.Regex]::Match($(_LinkerVersionString), '[1-9]\d*'))</_LinkerVersion>
295294
</PropertyGroup>
296295

0 commit comments

Comments
 (0)
Please sign in to comment.