Skip to content

Commit 7cf7894

Browse files
committed
Bump rspec
1 parent 39be46b commit 7cf7894

6 files changed

Lines changed: 181 additions & 125 deletions

File tree

‎.rubocop.yml‎

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
require:
1+
plugins:
22
- rubocop-rails
33
- rubocop-rspec
44

@@ -10,25 +10,37 @@ AllCops:
1010
NewCops: enable
1111
Exclude:
1212
- spec/dummy/db/schema.rb
13+
- spec/dummy/bin/setup
14+
- spec/dummy/bin/update
1315
- bin/rake
1416

17+
# Gemspec
18+
1519
Gemspec/RequiredRubyVersion:
1620
Enabled: false
1721

22+
# Layout
23+
1824
Layout/LineLength:
1925
Max: 80
2026

27+
# Metrics
28+
2129
Metrics/BlockLength:
2230
Exclude:
2331
- spec/**/*
2432

33+
# Style
34+
2535
Style/MixinUsage:
2636
Exclude:
2737
- spec/dummy/bin/*
2838

2939
Style/Documentation:
3040
Enabled: false
3141

42+
# Rails
43+
3244
Rails:
3345
Enabled: true
3446

@@ -38,6 +50,8 @@ Rails/FilePath:
3850
Rails/ApplicationRecord:
3951
Enabled: false
4052

53+
# RSpec
54+
4155
RSpec/ExampleLength:
4256
Max: 20
4357

‎.ruby-version‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3.1.3
1+
3.3.9

‎Gemfile‎

Lines changed: 31 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,35 @@ source "https://rubygems.org"
77
# development dependencies will be added by default to the :development group.
88
gemspec
99

10-
# Declare any dependencies that are still in development here instead of in
11-
# your gemspec. These might include edge Rails or gems from your path or
12-
# Git. Remember to move these dependencies to your gemspec before releasing
13-
# your gem to rubygems.org.
10+
# API to get the currencies.
11+
gem "money-open-exchange-rates"
1412

15-
# To use a debugger
16-
# gem 'byebug', group: [:development, :test]
13+
# DB for the dummy app.
14+
gem "sqlite3"
15+
16+
# Unit testing.
17+
gem "rspec"
18+
19+
# Unit testing with rails.
20+
gem "rspec-rails"
21+
22+
# Spec formatter for GitHub Actions.
23+
gem "rspec-github"
24+
25+
# Formatter for unit testing that Circle-CI enjoys.
26+
gem "rspec_junit_formatter"
27+
28+
# Travel through time in specs.
29+
gem "timecop"
30+
31+
# Useful for `binding.pry` in development.
32+
gem "pry"
33+
34+
# Style guide.
35+
gem "rubocop"
36+
37+
# Style guide for Rails.
38+
gem "rubocop-rails"
39+
40+
# Style guide for RSpec.
41+
gem "rubocop-rspec"

‎active_currency.gemspec‎

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -34,39 +34,4 @@ Gem::Specification.new do |s|
3434
# API to get the currencies.
3535
# >= 1.3.1 to prevent HTTPS error.
3636
s.add_dependency "eu_central_bank", ">= 1.3.1"
37-
38-
# Development dependencies
39-
40-
# API to get the currencies.
41-
s.add_development_dependency "money-open-exchange-rates"
42-
43-
# DB for the dummy app.
44-
s.add_development_dependency "sqlite3"
45-
46-
# Unit testing.
47-
s.add_development_dependency "rspec"
48-
49-
# Unit testing with rails.
50-
s.add_development_dependency "rspec-rails"
51-
52-
# Spec formatter for GitHub Actions.
53-
s.add_development_dependency "rspec-github"
54-
55-
# Formatter for unit testing that Circle-CI enjoys.
56-
s.add_development_dependency "rspec_junit_formatter"
57-
58-
# Travel through time in specs.
59-
s.add_development_dependency "timecop"
60-
61-
# Useful for `binding.pry` in development.
62-
s.add_development_dependency "pry"
63-
64-
# Style guide.
65-
s.add_development_dependency "rubocop"
66-
67-
# Style guide for Rails.
68-
s.add_development_dependency "rubocop-rails"
69-
70-
# Style guide for RSpec.
71-
s.add_development_dependency "rubocop-rspec"
7237
end

‎lib/active_currency/bank.rb‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
module ActiveCurrency
44
class Bank < Money::Bank::VariableExchange
55
def initialize(rate_store = ActiveCurrency::RateStore.new)
6-
super(rate_store)
6+
super
77
end
88
end
99
end

0 commit comments

Comments
 (0)