Skip to content

Commit 5ac68b0

Browse files
Favicons now work better
1 parent 0612b52 commit 5ac68b0

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/public/js/controls.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ function isIframeLoaded() {
130130
let iframe = document.querySelector(`[data-iframe-id="${currentTab}"]`);
131131
updateTabDetail("Loading...", "loading.gif");
132132
iframe.addEventListener('load', function() {
133-
updateTabDetail(iframe.contentWindow.document.title, iframe.contentWindow.document.querySelector('link[rel="favicon"]') ? iframe.contentWindow.document.querySelector('link[rel="favicon"]').href : "favicon.ico", currentTab);
133+
updateTabDetail(iframe.contentWindow.document.title, iframe.contentWindow.document.querySelector('link[rel="icon"]') ? iframe.contentWindow.document.querySelector('link[rel="icon"]').href : "favicon.ico", currentTab);
134134
updateURLBar(iframe.contentWindow.location.href);
135135
});
136136
}

src/public/js/tabs.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ el.addEventListener('activeTabChange', function ({ detail }) {
2626
if (iframeID) {
2727
showIframe(tabId);
2828
updateURLBar(iframeID.contentWindow.location.href);
29-
updateTabDetail(iframeID.contentWindow.document.title, iframeID.contentWindow.document.querySelector('link[rel="favicon"]') ? iframeID.contentWindow.document.querySelector('link[rel="favicon"]').href : 'favicon.ico', tabId);
29+
updateTabDetail(iframeID.contentWindow.document.title, iframeID.contentWindow.document.querySelector('link[rel="icon"]') ? iframeID.contentWindow.document.querySelector('link[rel="icon"]').href : 'favicon.ico', tabId);
3030
}
3131
});
3232
function showIframe(tabId) {

0 commit comments

Comments
 (0)