[Fix] Use the bot's user id for guild-member permission diagnostics#432
Merged
Merged
Conversation
GET /guilds/{id}/members/@me is not a Discord API route: unlike
/users/@me, the guild-members endpoint takes a real user id and rejects
the literal @me with 400 Invalid Form Body. Channel permission
diagnostics (settings default-channel save, comms status) failed against
real Discord while passing against the mock, which had implemented the
non-existent route.
Resolve the bot identity first and query members/{bot.id}; the mock now
rejects @me with the same 400 the real API returns, so provider code can
no longer pass against the mock while failing in production.
Found live during real-Discord dogfooding of the settings flow.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET /guilds/{id}/members/@meis not a Discord API route — unlike/users/@me, the guild-members endpoint takes a real user id and rejects the literal@mewith 400 Invalid Form Body. Channel permission diagnostics (settings default-channel save, comms status) failed against real Discord while passing against the mock, which had implemented the non-existent route.members/{bot.id}@meon that route with the same 400 the real API returns — provider code can no longer pass against the mock while failing in productionFound live within minutes of dogfooding the settings flow against a real bot; verified locally against real Discord after the fix.
🤖 Generated with Claude Code