Skip to content

Hide excluded sandbox providers during setup#322

Merged
mrubens merged 2 commits into
developfrom
codex/hide-excluded-setup-providers
Jul 14, 2026
Merged

Hide excluded sandbox providers during setup#322
mrubens merged 2 commits into
developfrom
codex/hide-excluded-setup-providers

Conversation

@mrubens

@mrubens mrubens commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • hide explicitly excluded sandbox providers from the onboarding provider picker
  • reject excluded provider choices and configuration submissions on the server
  • validate provider availability before provisioning locks or cleanup side effects
  • add client and server regression coverage

Root cause

The setup status correctly exposed deployment exclusions, but onboarding rendered the full provider catalog and its save handlers only checked catalog membership. That allowed an excluded provider to remain visible and accept submissions even though runtime provider resolution would ignore it.

Impact

Hosted deployments can exclude unsupported local compute options without those options appearing during onboarding. Unconfigured hosted providers remain selectable as before.

Validation

  • focused onboarding client tests
  • focused setup command server tests
  • pnpm --filter @roomote/web check-types
  • targeted ESLint and Prettier checks
  • pre-push lint:fast, check-types:fast, and knip

@roomote-roomote

roomote-roomote Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

No code issues found. See task

  • apps/web/src/app/(onboarding)/setup/hooks.ts:390-421: A provider selected before deployment exclusions change is still treated as selected through setupNewState.computeProvider. The flow skips the provider picker (and can skip config when the old provider remains configured), then starts onboarding even though buildSetupComputeStatus has filtered that provider out. Use the filtered computeSetup.selectedProvider when deciding the compute steps, and reject/reselect a stale excluded choice before launch.

Reviewed 309f476

@mrubens
mrubens marked this pull request as ready for review July 14, 2026 16:15
@mrubens
mrubens merged commit 963a04a into develop Jul 14, 2026
17 checks passed
@mrubens
mrubens deleted the codex/hide-excluded-setup-providers branch July 14, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant