[Fix] Review notifications omit resolve actions for open feedback - #1165
Closed
roomote-roomote[bot] wants to merge 2 commits into
Closed
[Fix] Review notifications omit resolve actions for open feedback#1165roomote-roomote[bot] wants to merge 2 commits into
roomote-roomote[bot] wants to merge 2 commits into
Conversation
Contributor
| : []), | ||
| ...(failedCheckNames.length > 0 | ||
| ? [ | ||
| `Investigate and fix the failing CI checks: ${failedCheckNames.join(', ')}.`, |
Contributor
There was a problem hiding this comment.
CI check names are untrusted PR-controlled data (a pull_request workflow can assign a job an instruction-looking name), but this fallback interpolates them verbatim into followUpPrompt. That prompt is auto-dispatched directly to the agent when auto-handle is enabled, so a malicious check name can become an agent instruction without user interaction. Preserve the label as quoted data or sanitize it before building the executable follow-up prompt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Internal maintainer request; no linked issue.
Why this PR exists
Actionable pull-request notifications could render as informational messages without resolve actions when triage returned incomplete or contradictory output, even though live PR state still had unresolved feedback, failing CI, or merge conflicts.
What changed
How it was tested
Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changeset