[Improve] Route chat suggestions when users start them - #1149
Merged
daniel-lxs merged 2 commits intoAug 7, 2026
Conversation
Contributor
|
No code issues found. See task
Reviewed ddc70e2 |
![roomote-community[bot]](https://avatars.githubusercontent.com/u/211522643?s=60&v=4){kind=small}
Launch routing now has a single rule: cards whose tracked-message metadata carries launchRouting: 'router' are presentation-only chat-reply suggestions, and every claim function nulls their pinned launch metadata before returning. Downstream launchers just use field presence, so the per-surface launchRouting !== 'router' guards, the suggestionGroupKey heuristic, and the legacy taskRuns payloadKind lookup are gone. Unmarked cards (scan, setup, and cards posted before the marker existed) keep their verified pinned targets on every surface, including current-thread scan suggestions on Discord, Telegram, and Teams.
daniel-lxs
approved these changes
Aug 7, 2026
daniel-lxs
left a comment
daniel-lxs
left a comment
Member
There was a problem hiding this comment.
Reviewed the full diff, trimmed the launch-routing logic to a single claim-boundary rule, and smoke-tested the Slack reaction flow against the mock harness (router branch taken, claim released cleanly on routing fallback). Scan and setup suggestions keep their verified pinned targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
launchRouting: 'router'in tracked-message metadata when posted (Slack, Discord, Telegram, Teams).Why this change was made
Chat suggestions could select and persist the wrong repository before a user approved them. Repository selection belongs to the task router at launch time, while verified scheduled and setup automation targets must remain deterministic.
Impact
Users see simpler suggestion cards, and approved chat suggestions run in the workspace selected by Roomote's router. Scan and setup suggestions retain their repository, environment, priority, category, and investigation context behavior on all surfaces. Cards posted before this release launch exactly as they did before.