Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-push tests fail when downloading mongodb #17368

Closed
mrtndwrd opened this issue Apr 20, 2020 · 5 comments
Closed

pre-push tests fail when downloading mongodb #17368

mrtndwrd opened this issue Apr 20, 2020 · 5 comments
Labels
stat: stale Stale issues will be automatically closed if no activity

Comments

@mrtndwrd
Copy link
Contributor

Description:

Before I can push any change to a repo, the pre-push hook runs meteor npm run testunit. This fails on my machine for several reasons.

Steps to reproduce:

  1. Clone the Rocket.Chat repository
  2. Run meteor npm run testunit
  3. 1) Sessions Aggregates tests fail (logs at the bottom of this issue)

Expected behavior:

Tests succeed (at least on the master branch)

Actual behavior:

Tests fail, see logs:

tests-normal.txt

I tried apt-geting mongodb-server-core (v3.6.3), setting the MONGO_URL to my own server (mongodb://localhost:27017), then the tests fail with this output:

tests-local-mongo.txt

Server Setup Information:

  • Version of Rocket.Chat Server: current master (0a16a86 / 3.1.1)
  • Operating System: Ubuntu 18.04
  • Deployment Method: n/a
  • Number of Running Instances: n/a
  • DB Replicaset Oplog: n/a
  • NodeJS Version: v13.11.0
  • MongoDB Version: v3.6.3
@mrtndwrd
Copy link
Contributor Author

I worked around the issue by changing the mongoDB version in ./app/models/server/models/Sessions.tests.js to '4.0.5'.

I got the idea from this issue: mongodb-js/mongodb-download#36

It's possible that I'm the only one running into this issue because I'm on Ubuntu 18.04 and other devs are not?

It seems there are two possible solutions:

  1. use a newer version of Mongodb for these tests
  2. Wait for mongodb-download to fix the issue and upgrade the dependency

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stat: stale Stale issues will be automatically closed if no activity label Jun 20, 2020
@sampaiodiego
Copy link
Member

@pierre-lehnen-rc were you able to fix this on your env by installing the old libssl version?

@github-actions github-actions bot removed the stat: stale Stale issues will be automatically closed if no activity label Jun 21, 2020
@pierre-lehnen-rc
Copy link
Contributor

I messed up my libs when I tried to downgrade it and didn't look at it again, but I had debugged the tests and it was definitely caused by the libssl version.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stat: stale Stale issues will be automatically closed if no activity label Aug 21, 2020
@github-actions github-actions bot closed this as completed Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: stale Stale issues will be automatically closed if no activity
Projects
None yet
Development

No branches or pull requests

3 participants