Request to /api/v1/chat.syncMessages fails with The \"lastUpdate\" query parameter must be a valid date.

[svenseeberg]

Description:

The app sends requests to /api/v1/chat.syncMessages?roomId=ROOMID&lastUpdate=undefined. The back end returns an error:

"level":35,"time":"2024-12-13T19:57:58.602Z","pid":1040862,"hostname":"rocketchat","name":"API","method":"GET","url":"/api/v1/chat.syncMessages?roomId=ROOMID&lastUpdate=undefined","userId":"USERID","userAgent":"RC Mobile; android 9; v4.55.0 (70132)","host":"rc.example.com","remoteIP":"USERIP","err":{"type":"errorClass","message":"The \"lastUpdate\" query parameter must be a valid date. [error-roomId-param-invalid]","stack":"Error: The \"lastUpdate\" query parameter must be a valid date. [error-roomId-param-invalid]\n    at app/api/server/v1/chat.ts:91:11\n    at /opt/Rocket.Chat/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/fiber_pool.js:43:40\n => awaited here:\n    at Function.Promise.await (/opt/Rocket.Chat/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/promise_server.js:56:12)\n    at packages/meteor.js:367:22\n    at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1389:31)\n    at app/api/server/api.ts:649:39\n    at /opt/Rocket.Chat/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/fiber_pool.js:43:40","isClientSafe":true,"error":"error-roomId-param-invalid","reason":"The \"lastUpdate\" query parameter must be a valid date.","errorType":"Meteor.Error"},"status":400,"responseTime":2,"msg":"The \"lastUpdate\" query parameter must be a valid date. [error-roomId-param-invalid]"}

Environment Information:

• Rocket.Chat Server Version: 6.13.1
• Rocket.Chat App Version: v4.55.0 and others
• Device Name:
• OS Version: Android/iOS all versions

Steps to reproduce:

I cannot provide exact steps to reproduce.

Expected behavior:

The app should always send a date in lastUpdate. Alternatively, the server should accept undefined lastUpdate.

Actual behavior:

N/A

Additional context:

We have some reports by users that they click on push notifications but the message does not load in channels. We suspect that this could be related.

[diegolmello]

@OtavioStasiak could it be related to #5992?

[OtavioStasiak]

I am not sure, but it could be related to the recent changes made to load and getLastUpdate. I will test it here and try to reproduce.

[anicoa]

Any news on this? We have this problem also after upgrading to 7.x

[Rohit3523]

Can you share more information about this issue like when this error occurred and steps so I can give it a try.
It would be great if anyone is ready to provide me your workspace url because it's a time taking process to setup one 😔

[OtavioStasiak]

I couldn't reproduce this issue.
@svenseeberg is the error happening in some specific case (EX: just if I create new room)?
@anicoa could you provide more information about it?

[diegolmello]

As I said on #6250, that PR could fix the issue theoretically.
I was not able to reproduce the issue, so things are harder to confirm.

Just submitted a beta version to the stores.
It should take a few time until Apple/Google approve though.
Can you test it for a few days before it goes public?

Rocket.Chat iOS: 4.59.0.76580 (https://testflight.apple.com/join/3gcYeoMr)
Rocket.Chat Android: 4.59.0.76581 (https://play.google.com/store/apps/details?id=chat.rocket.android)

Reopening this issue until we have a confirmation from your side.
Let me know if you have any questions.

[anicoa]

Don't know if its related: often threads arent shown correctly (three different servers).

I can not see, that it is a thread. If I open a new thread, all the messages are shown.

Regarding lastUpdate we will check server-logs

[anicoa]

Regarding lastUpdate=undefined: i greped our log files. We have only one occurence (RC Mobile; ios 18.4; v4.51.0 (64829)) for the last days. So I guess it's solved?

[diegolmello]

@anicoa If your workspace is 7.1+, it's not going to make that request like that

/api/v1/chat.syncMessages?roomId=ROOMID&lastUpdate=undefined

It should appear like this

/api/v1/chat.syncMessages?roomId=ROOMID&next=NEXT&count=50&type=UPDATED"
/api/v1/chat.syncMessages?roomId=ROOMID&next=NEXT&count=50&type=DELETED"