Commit caf0831
committed
ci: skip electron test on Node 26.1+ extract-zip regression
Node 26.1.0 introduces an incompatibility with extract-zip 2.0.1
(used by electron's install.js): extraction silently terminates
after the first entry, leaving the prebuilt binary unextracted and
node_modules/electron/path.txt missing. Verified locally:
- Node 26.0.0 + electron@34.0.0 -> install OK, require() OK
- Node 26.1.0 + electron@34.0.0 -> install silently broken,
require() throws 'Electron failed to install correctly'
- Node 26.1.0 + electron@latest -> install silently broken,
require() throws ENOENT on path.txt
Both broken-install messages are caught in test/electron/run_test.js
and now produce a clear skip with exit code 0, plus the underlying
require() error is logged so the cause is visible in CI logs.
Also add --foreground-scripts to the electron install in npm test so
postinstall stdout/stderr is no longer hidden by npm's grouping.1 parent f65469d commit caf0831
2 files changed
Lines changed: 30 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
10 | 39 | | |
11 | 40 | | |
12 | 41 | | |
| |||
0 commit comments