Unvendor gtest

[Timple]

Should solve #59

[Tobias-Fischer]

You also need to bump the build number

[Timple]

Which version? And to what?

The gtest version? I was hoping that would be resolved to something that matches the users requirements.

[Tobias-Fischer]

The package is configured to always install the vendored files, see https://github.com/ros2-gbp/googletest-release/tree/release/kilted/gtest_vendor - so this needs more work :(. @traversaro to advise please

[traversaro]

Oh no, sorry I did not look into detail here. The issue is much more complex that I expected. Not only the gtest_vendor package does not uses the ament_vendor helper, but it kind of install a complete sourcecode of gtest, and a CMakeLists.txt to compile it, instead of just installing a gest compiler library (and gmock_vendor does something similar).

The main problem is that the main consumer here is https://github.com/ament/ament_cmake/blob/abd86f5a12eb085cd975ad9e02ff6b66cc372170/ament_cmake_gtest/ament_cmake_gtest-extras.cmake#L18-L113, that kind of expect that strange distribution of gtest in that format. If I recall correctly that is the old way of Debian for packaging googletest, but the strange thing is that modern versions of ubuntu package gtest as a normal library, exactly like conda-forge does, see https://packages.ubuntu.com/noble/amd64/libgtest-dev/filelist .

The only way to properly solving this is to also patch ament_cmake_gtest . I can work on this, but it will take a few hours, so hopefully I will be able to do that in the weekend, not before.

[Timple]

That would be great!

Perhaps now is actually a good time. Because this might get in before lyrical and prevent issues in the next 5 years 😄