Skip to content

Question: Rationale for using rays_o instead of rays_o × rays_d for Plucker embedding's first three dimensions #38

@sustecher

Description

@sustecher

Hi @Robbyant,

I noticed in the implementation of Plücker embedding at cam_utils.py#L115, the first three dimensions use rays_o directly.
In contrast, a more common/general practice for Plücker embedding (as seen in CamI2V/base/base.py#L156) uses the cross product of rays_o and rays_d (rays_o × rays_d) for these dimensions.

I'm curious to understand the design decision here:

  1. What is the rationale for using rays_o instead of rays_o × rays_d in this implementation?
  2. Are there specific use cases/scenarios where this choice is more appropriate for the lingbot-world project?

Thanks for your time and clarification!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions