-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding quality flags to the commandLineArgs config does not work #99
Comments
Hey, |
Yeah I've been working with that, however you get some issues with the sideview if you change the quality like that because it exports to a different folder. In my head I imagine a command in the command palate that you can run, then you just get a list of low, medium, high, etc. |
Can confirm, adding '-qm' to the commandLineArgs config does not work as the extension seems to always look for something in the 1080p60 folder. |
I will look into this issue. Thank you guys for raising it. |
Same here, it's definitely a needed feature. Just wanted to raise +1. 👍 |
A hacky way to get around this is to add -ql to the command line args, create a symlink from the 480p15 file to the 1080p60 folder. It's gross but I prefer it to disabling preview, using -pql and then watching in vlc. When you want your final render in high quality just remember to remove the -ql from the command line args or change it to -qp or -qk for even higher than 1080p. |
FYI, an alternative way to do this is to use a manim configuration file. The extension is able to read and change its settings. |
Can you advise on what to add to the manim.cfg because when I add quality = low it did not work. Thanks |
Yes, it's |
Oh, my apologies, I did not see that this ticket existed before creating these ones:
FYI available quality options that can be put into the |
I was considering just doing this as a pull request because it seems pretty simple, at least on paper, however, I then remembered that I am kinda stupid and gave up after realizing I don't know how VSC extensions work.
Honestly, a advanced user would probably get even more use out of a command to freely change command line arguments as a whole, but as previously stated, I'm kinda stupid, so I would only be editing output quality flags, hence why I suggested that it have its own dedicated command
At the end of the day, I can just go edit the command line args in settings and edit it there but I'm lazy and this seems easier.
The text was updated successfully, but these errors were encountered: