Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding quality flags to the commandLineArgs config does not work #99

Open
Foocett opened this issue Sep 30, 2024 · 10 comments
Open

Adding quality flags to the commandLineArgs config does not work #99

Foocett opened this issue Sep 30, 2024 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@Foocett
Copy link

Foocett commented Sep 30, 2024

I was considering just doing this as a pull request because it seems pretty simple, at least on paper, however, I then remembered that I am kinda stupid and gave up after realizing I don't know how VSC extensions work.

Honestly, a advanced user would probably get even more use out of a command to freely change command line arguments as a whole, but as previously stated, I'm kinda stupid, so I would only be editing output quality flags, hence why I suggested that it have its own dedicated command

At the end of the day, I can just go edit the command line args in settings and edit it there but I'm lazy and this seems easier.

@Rickaym
Copy link
Owner

Rickaym commented Sep 30, 2024

Hey,
How do you imagine the feature? Are you alking about customizing extra command line arguments? This one should be in the settings manim-sideview.commandLineArgs.

@Foocett
Copy link
Author

Foocett commented Oct 2, 2024

Yeah I've been working with that, however you get some issues with the sideview if you change the quality like that because it exports to a different folder. In my head I imagine a command in the command palate that you can run, then you just get a list of low, medium, high, etc.
I bring up command line arguments because I'm sure more advanced users would get use out of it, but a quality command I think would be a more relevant feature.

@Segfault1602
Copy link

Can confirm, adding '-qm' to the commandLineArgs config does not work as the extension seems to always look for something in the 1080p60 folder.

@Rickaym
Copy link
Owner

Rickaym commented Oct 5, 2024

I will look into this issue. Thank you guys for raising it.

@barisertemli
Copy link

Same here, it's definitely a needed feature. Just wanted to raise +1. 👍

@confusion12345
Copy link

confusion12345 commented Oct 19, 2024

A hacky way to get around this is to add -ql to the command line args, create a symlink from the 480p15 file to the 1080p60 folder. It's gross but I prefer it to disabling preview, using -pql and then watching in vlc.

When you want your final render in high quality just remember to remove the -ql from the command line args or change it to -qp or -qk for even higher than 1080p.

@Rickaym
Copy link
Owner

Rickaym commented Oct 20, 2024

FYI, an alternative way to do this is to use a manim configuration file. The extension is able to read and change its settings.

@confusion12345
Copy link

FYI, an alternative way to do this is to use a manim configuration file. The extension is able to read and change its settings.

Can you advise on what to add to the manim.cfg because when I add quality = low it did not work.

Thanks

@Rickaym
Copy link
Owner

Rickaym commented Oct 21, 2024

FYI, an alternative way to do this is to use a manim configuration file. The extension is able to read and change its settings.

Can you advise on what to add to the manim.cfg because when I add quality = low it did not work.

Thanks

Yes, it's low_quality

@Rickaym Rickaym added the bug Something isn't working label Oct 21, 2024
@Rickaym Rickaym changed the title Add command to change output quality flags on the fly Adding quality flags to the commandLineArgs config does not work Oct 21, 2024
@e-dervieux
Copy link

Oh, my apologies, I did not see that this ticket existed before creating these ones:

FYI available quality options that can be put into the config.cfg file are: 'fourk_quality', 'production_quality', 'high_quality', 'medium_quality', 'low_quality', 'example_quality'. All of them are defined here.

@Rickaym Rickaym added enhancement New feature or request and removed bug Something isn't working labels Oct 30, 2024
@Rickaym Rickaym self-assigned this Oct 30, 2024
Rickaym added a commit that referenced this issue Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants