Fixes #4390: Code validation changes added

Author: saravanan477

.codeclimate.yml

@@ -1,30 +1,134 @@
----
-engines:
+version: "2"
+checks:
+  argument-count:
+    enabled: true
+    config:
+      threshold: 10
+  complex-logic:
+    enabled: false
+  file-lines:
+    config:
+      threshold: 10000
+  similar-code:
+    enabled: false
+  identical-code:
+    enabled: false
+  method-complexity:
+    enabled: true
+    config:
+      threshold: 10000
+  method-count:
+    enabled: true
+    config:
+      threshold: 1000
+  method-lines:
+    config:
+      threshold: 10000
+  nested-control-flow:
+    enabled: true
+    config:
+      threshold: 10000
+  return-statements:
+    enabled: true
+    config:
+      threshold: 100
+plugins:
   csslint:
     enabled: true
+    checks:
+      adjoining-classes:
+        enabled: false
+      box-model:
+        enabled: false
+      box-sizing:
+        enabled: false
+      compatible-vendor-prefixes:
+        enabled: false
+      display-property-grouping:
+        enabled: false
+      duplicate-background-images:
+        enabled: false
+      duplicate-properties:
+        enabled: false
+      empty-rules:
+        enabled: false
+      fallback-colors:
+        enabled: false
+      gradients:
+        enabled: false
+      known-properties:
+        enabled: false
+      important:
+        enabled: false
+      order-alphabetical:
+        enabled: false
+      outline-none:
+        enabled: false
+      overqualified-elements:
+        enabled: false
+      qualified-headings:
+        enabled: false
+      universal-selector:
+        enabled: false
+      unqualified-attributes:
+        enabled: false
+      regex-selectors:
+        enabled: false
+      star-property-hack:
+        enabled: false
+      text-indent:
+        enabled: false
+      underscore-property-hack:
+        enabled: false
+      zero-units:
+        enabled: false
   eslint:
     enabled: true
   fixme:
     enabled: true
+    checks:
+      TODO:
+        enabled: false
+      XXX:
+        enabled: false
   phpmd:
-    enabled: true
+    enabled: false
     checks:
+      CleanCode/BooleanArgumentFlag:
+        enabled: false
+      CleanCode/ElseExpression:
+        enabled: false
+      CleanCode/IfStatementAssignment:
+        enabled: false
+      CleanCode/MissingImport:
+        enabled: false
+      CleanCode/StaticAccess:
+        enabled: false
+      Controversial/CamelCaseMethodName:
+        enabled: false
       Controversial/CamelCaseParameterName:
         enabled: false
+      Controversial/CamelCasePropertyName:
+        enabled: false
+      Controversial/CamelCaseVariableName:
+        enabled: false
+      Controversial/Superglobals:
+        enabled: false
+      CyclomaticComplexity:
+        enabled: false
+      Design/LongMethod:
+        enabled: false
+      Design/NpathComplexity:
+        enabled: false
       Naming/LongVariable:
         enabled: false
       Naming/ShortVariable:
         enabled: false
       order-alphabetical:
         enabled: false
-ratings:
-  paths:
-  - "**.css"
-  - "**.js"
-  - "**.php"
-exclude_paths:
-- api_explorer/*
-- build/*
-- client/css/converse.css
-- client/js/libs/*
-- server/php/libs/vendors/**/*
+exclude_patterns:
+- "api_explorer/*"
+- "build/*"
+- "client/css/converse.css"
+- "client/js/libs/*"
+- "server/php/libs/vendors/**/*"

client/css/bootstrap-datetimepicker.min.css

@@ -186,7 +186,7 @@
 .datetimepicker table tr td.today:hover,
 .datetimepicker table tr td.today.disabled,
 .datetimepicker table tr td.today.disabled:hover {
-	background-color: ##f47564;
+	background-color: #f47564;
 	/*background-image: -moz-linear-gradient(top, #fdd49a, #fdf59a);
 	background-image: -ms-linear-gradient(top, #fdd49a, #fdf59a);
 	background-image: -webkit-gradient(linear, 0 0, 0 100%, from(#fdd49a), to(#fdf59a));

diagnose.php

@@ -96,17 +96,20 @@
     }
 }
 function _is_writable_recursive($dir) {
-    if (!($folder = @opendir($dir))) {
-        return false;
-    }
-    while ($file = readdir($folder)) {
-        if ($file != '.' && $file != '..' && (!is_writable($dir . '/' . $file) || (is_dir($dir . '/' . $file) && !_is_writable_recursive($dir . '/' . $file)))) {
-            closedir($folder);
+    if (is_dir($dir)){
+        $folder = opendir($dir);
+        if (!($folder)) {
             return false;
         }
+        while (($file = readdir($folder)) !== false) {
+            if ($file != '.' && $file != '..' && (!is_writable($dir . '/' . $file) || (is_dir($dir . '/' . $file) && !_is_writable_recursive($dir . '/' . $file)))) {
+                closedir($folder);
+                return false;
+            }
+        }
+        closedir($folder);
+        return true;
     }
-    closedir($folder);
-    return true;
 }
 if (file_exists(APP_PATH . '/client/apps/r_ldap_login/app.json')) {
     $is_having_ldap_plugin = true;