Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance issues when adding large number of entities #27

Open
fbacall opened this issue Aug 31, 2022 · 2 comments
Open

Performance issues when adding large number of entities #27

fbacall opened this issue Aug 31, 2022 · 2 comments

Comments

@fbacall
Copy link
Collaborator

fbacall commented Aug 31, 2022

See: https://github.com/kit-data-manager/ro-crate-benchmarks

image
@fbacall
Copy link
Collaborator Author

fbacall commented Aug 31, 2022

Probably due to how entities are looked up by iterating through an array, rather than using some kind of hash map

fbacall added a commit that referenced this issue Aug 31, 2022
@fbacall
Store entities in Sets for fast lookups. #27
b831345
@fbacall
Copy link
Collaborator Author

fbacall commented Aug 31, 2022

^ cuts time to add 500 entities from 7.5 secs to ~0.4 secs on local machine

fbacall added a commit that referenced this issue Aug 31, 2022
@fbacall
Use Set consistently for collections of entities. #27
c7b75c0
fbacall added a commit that referenced this issue Sep 1, 2022
@fbacall
Memoize crate's canonical ID. Speeds up "claim" method. #27
e9aead0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fbacall