From 79252a518ece80203c2c3d9407673126ad4a4686 Mon Sep 17 00:00:00 2001 From: Foxtrek_64 Date: Thu, 28 Dec 2023 08:56:19 -0600 Subject: [PATCH 1/3] Add TargetNetStandard switch --- Remora.Sdk/Sdk/Sdk.props | 3 ++- Remora.Sdk/Sdk/Sdk.targets | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/Remora.Sdk/Sdk/Sdk.props b/Remora.Sdk/Sdk/Sdk.props index e5e2ca0..4613002 100644 --- a/Remora.Sdk/Sdk/Sdk.props +++ b/Remora.Sdk/Sdk/Sdk.props @@ -11,7 +11,8 @@ net8.0 - netstandard2.1;net6.0;net7.0;$(ExecutableFrameworks) + net6.0;net7.0;$(ExecutableFrameworks) + true diff --git a/Remora.Sdk/Sdk/Sdk.targets b/Remora.Sdk/Sdk/Sdk.targets index 6dfa17a..7cabd71 100644 --- a/Remora.Sdk/Sdk/Sdk.targets +++ b/Remora.Sdk/Sdk/Sdk.targets @@ -11,6 +11,9 @@ $(ExecutableFrameworks) + + + netstandard2.1;$(TargetFrameworks) From e91a87d4796a6788926d8c00989f58937fd6a027 Mon Sep 17 00:00:00 2001 From: Foxtrek_64 Date: Thu, 28 Dec 2023 09:09:01 -0600 Subject: [PATCH 2/3] Update Readme --- Remora.Sdk/README.md | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/Remora.Sdk/README.md b/Remora.Sdk/README.md index 34f8d20..69c3c98 100644 --- a/Remora.Sdk/README.md +++ b/Remora.Sdk/README.md @@ -47,12 +47,16 @@ The following properties are defined by the SDK. ### Framework Targets The following properties are defined by the SDK. -| Property | Value | Overridable | -|-----------------------|------------------------------|-------------| -| LibraryFrameworks* | netstandard2.1;net6.0;net7.0 | Yes | -| ExecutableFrameworks* | net7.0 | Yes | -| TargetFramework | | Yes | -| TargetFrameworks | (varies) | Yes | +| Property | Value | Overridable | +|-----------------------|---------------|-------------| +| LibraryFrameworks* | net6.0;net7.0 | Yes | +| ExecutableFrameworks* | net7.0 | Yes | +| TargetFramework | | Yes | +| TargetFrameworks | (varies) | Yes | +| TargetNetStandard | true | Yes | + +If `TargetNetStandard` is `true`, `netstandard2.1;` will be prepended to +LibraryFrameworks: `netstandard2.1;net6.0;net7.0`. Notably, the SDK defines a set of standard targets for libraries and frameworks, then applies this to the `TargetFrameworks` property based on the project's From f39e3691666243e04ce6f3ea083e959fde2b9fdd Mon Sep 17 00:00:00 2001 From: Foxtrek_64 Date: Sun, 31 Dec 2023 13:46:18 -0600 Subject: [PATCH 3/3] Fix readme and sdk.targets --- Remora.Sdk/README.md | 4 ++-- Remora.Sdk/Sdk/Sdk.targets | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Remora.Sdk/README.md b/Remora.Sdk/README.md index 69c3c98..a3d5620 100644 --- a/Remora.Sdk/README.md +++ b/Remora.Sdk/README.md @@ -55,8 +55,8 @@ The following properties are defined by the SDK. | TargetFrameworks | (varies) | Yes | | TargetNetStandard | true | Yes | -If `TargetNetStandard` is `true`, `netstandard2.1;` will be prepended to -LibraryFrameworks: `netstandard2.1;net6.0;net7.0`. +If `TargetNetStandard` is `true`, `netstandard2.1` will be included as a target when building libraries. +Set the property to `false` if this is undesirable. Notably, the SDK defines a set of standard targets for libraries and frameworks, then applies this to the `TargetFrameworks` property based on the project's diff --git a/Remora.Sdk/Sdk/Sdk.targets b/Remora.Sdk/Sdk/Sdk.targets index 7cabd71..f67f5d3 100644 --- a/Remora.Sdk/Sdk/Sdk.targets +++ b/Remora.Sdk/Sdk/Sdk.targets @@ -10,10 +10,10 @@ $(LibraryFrameworks) - $(ExecutableFrameworks) + netstandard2.1;$(LibraryFrameworks) - netstandard2.1;$(TargetFrameworks) + $(ExecutableFrameworks)