Skip to content

Remove JSON.Net dependency #663

Open
@dylanvdmerwe

Description

@dylanvdmerwe

What version of PushSharp are you using?

4.x

Describe your issue:

Is there really a need to have a dependency on the JSON.Net library anymore now that developers are responsible for creating their own message payloads?

Currently for GCM and Apns:
1

2

The Data and Payload properties respectively expect a JObject. This creates a hard dependency on the JSON.Net library.

I firmly believe it should be up to the developers to create a proper payload and that it is their responsibility to serialize the JSON correctly. As such, the Notification classes should just take a string object instead of a JObect.

Benefits of this:

  • Removing hard dependencies on external libs. Reduces version conflicts, binary size, etc.
  • Allows developers to make use of their own serializers like ServiceStack or Jil (or JSON.Net if they so chose)

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions