Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeviceSubscriptonExpiredException misspelled #656

Open
breyed opened this issue Mar 18, 2016 · 2 comments
Open

DeviceSubscriptonExpiredException misspelled #656

breyed opened this issue Mar 18, 2016 · 2 comments
Assignees
Labels
Milestone

Comments

@breyed
Copy link

breyed commented Mar 18, 2016

DeviceSubscriptonExpiredException is misspelled. This causes the example in the ReadMe (which has the proper spelling) to not work. The underlying problem is that Code Analysis is not being run on this library; it would have detected the spelling error.

@Redth Redth added this to the 5.0 milestone Mar 24, 2016
@Redth Redth added the bug label Mar 24, 2016
@Redth
Copy link
Owner

Redth commented Mar 24, 2016

Thanks, this has been fixed in v4.0.1.

Basically I've added a properly spelled class which subclasses the misspelled one (so that it won't break users' code). The misspelled one has been marked obsolete and will be removed in the next major version bump.

@Redth Redth self-assigned this Mar 24, 2016
@l3ender
Copy link

l3ender commented Apr 1, 2016

I'm referencing 4.0.4 and see the new exception class, but the actual exception that is being thrown is still the misspelled variant. I see you've committed an update 2 days ago...could that be escalated and pushed to Nuget?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants