In-Progress Redistimeseries v1.4 support #10

filipecosta90 · 2020-12-21T12:35:11Z

No description provided.

…n a common format across targets

…datapoints progress...

…_load_redistimeseries/main.go ( different from redis spec )

sonatype-lift · 2022-06-25T17:43:51Z

scripts/generate_queries_redistimeseries.sh

+
+set -x
+
+EXE_DIR=${EXE_DIR:-$(dirname $0)}


SC2086: Double quote to prevent globbing and word splitting.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-25T17:43:52Z

scripts/generate_queries_redistimeseries.sh

+set -x
+
+EXE_DIR=${EXE_DIR:-$(dirname $0)}
+source ${EXE_DIR}/query_common.sh


SC1091: Not following: ./query_common.sh was not specified as input (see shellcheck -x).

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-25T17:43:53Z

scripts/generate_queries_redistimeseries.sh

+
+EXE_DIR=${EXE_DIR:-$(dirname $0)}
+source ${EXE_DIR}/query_common.sh
+source ${EXE_DIR}/redistimeseries_common.sh


SC1091: Not following: ./redistimeseries_common.sh was not specified as input (see shellcheck -x).

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-25T17:43:54Z

scripts/generate_queries_redistimeseries.sh

+set -x
+
+EXE_DIR=${EXE_DIR:-$(dirname $0)}
+source ${EXE_DIR}/query_common.sh


SC2086: Double quote to prevent globbing and word splitting.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-25T17:43:55Z

scripts/generate_queries_redistimeseries.sh

+
+EXE_DIR=${EXE_DIR:-$(dirname $0)}
+source ${EXE_DIR}/query_common.sh
+source ${EXE_DIR}/redistimeseries_common.sh


SC2086: Double quote to prevent globbing and word splitting.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-25T17:43:56Z

scripts/generate_queries_redistimeseries.sh

+mkdir -p ${BULK_DATA_DIR}
+
+# Ensure queries dir is clean
+rm -rf ${BULK_DATA_DIR}/queries_${USE_CASE}_${FORMAT}_${SCALE}*


SC2086: Double quote to prevent globbing and word splitting.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-25T17:43:57Z

scripts/generate_queries_redistimeseries.sh

+SKIP_IF_EXISTS=${SKIP_IF_EXISTS:-"TRUE"}
+
+# Ensure DATA DIR available
+mkdir -p ${BULK_DATA_DIR}


SC2086: Double quote to prevent globbing and word splitting.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-25T17:43:58Z

scripts/generate_queries_redistimeseries.sh

+mkdir -p ${BULK_DATA_DIR}
+
+# Ensure queries dir is clean
+rm -rf ${BULK_DATA_DIR}/queries_${USE_CASE}_${FORMAT}_${SCALE}*


SC2086: Double quote to prevent globbing and word splitting.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-25T17:44:00Z

scripts/generate_queries_redistimeseries.sh

+mkdir -p ${BULK_DATA_DIR}
+
+# Ensure queries dir is clean
+rm -rf ${BULK_DATA_DIR}/queries_${USE_CASE}_${FORMAT}_${SCALE}*


SC2086: Double quote to prevent globbing and word splitting.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-25T17:44:01Z

scripts/generate_queries_redistimeseries.sh

+    QUERY_DATA_FILE_NAME="queries_${USE_CASE}_${FORMAT}_${SCALE}_${QUERY_TYPE}_${QUERIES}.dat"
+    echo "Generating ${QUERY_DATA_FILE_NAME}:"
+    ${EXE_FILE_NAME} \
+        --format=${FORMAT} \


SC2086: Double quote to prevent globbing and word splitting.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-25T17:44:02Z

scripts/generate_queries_redistimeseries.sh

+mkdir -p ${BULK_DATA_DIR}
+
+# Ensure queries dir is clean
+rm -rf ${BULK_DATA_DIR}/queries_${USE_CASE}_${FORMAT}_${SCALE}*


SC2086: Double quote to prevent globbing and word splitting.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-25T17:44:03Z

scripts/generate_queries_redistimeseries.sh

+    echo "Generating ${QUERY_DATA_FILE_NAME}:"
+    ${EXE_FILE_NAME} \
+        --format=${FORMAT} \
+        --queries=${QUERIES} \


SC2086: Double quote to prevent globbing and word splitting.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-25T17:44:04Z

scripts/generate_queries_redistimeseries.sh

+    ${EXE_FILE_NAME} \
+        --format=${FORMAT} \
+        --queries=${QUERIES} \
+        --query-type=${QUERY_TYPE} \


SC2086: Double quote to prevent globbing and word splitting.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-25T17:44:06Z

scripts/generate_queries_redistimeseries.sh

+        --queries=${QUERIES} \
+        --query-type=${QUERY_TYPE} \
+        --scale=${SCALE} \
+        --seed=${SEED} \


SC2086: Double quote to prevent globbing and word splitting.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-25T17:44:07Z

scripts/generate_queries_redistimeseries.sh

+        --scale=${SCALE} \
+        --seed=${SEED} \
+        --timestamp-start=${TS_START} \
+        --timestamp-end=${TS_END} \


SC2086: Double quote to prevent globbing and word splitting.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-25T17:44:08Z

scripts/generate_queries_redistimeseries.sh

+        --format=${FORMAT} \
+        --queries=${QUERIES} \
+        --query-type=${QUERY_TYPE} \
+        --scale=${SCALE} \


SC2086: Double quote to prevent globbing and word splitting.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-25T17:44:10Z

scripts/generate_queries_redistimeseries.sh

+        --query-type=${QUERY_TYPE} \
+        --scale=${SCALE} \
+        --seed=${SEED} \
+        --timestamp-start=${TS_START} \


SC2086: Double quote to prevent globbing and word splitting.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-25T17:45:12Z

cmd/tsbs_run_queries_questdb/http_client.go

+type HTTPClientDoOptions struct {
+	Debug                int
+	PrettyPrintResponses bool
+	chunkSize            uint64


structcheck: chunkSize is unused

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-25T17:45:14Z

cmd/tsbs_run_queries_questdb/http_client.go

+	Debug                int
+	PrettyPrintResponses bool
+	chunkSize            uint64
+	database             string


structcheck: database is unused

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-25T17:45:19Z

cmd/tsbs_run_queries_questdb/http_client.go

+	"github.com/timescale/tsbs/pkg/query"
+)
+
+var bytesSlash = []byte("/") // heap optimization


unused: var bytesSlash is unused

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-25T17:45:22Z

cmd/tsbs_load_questdb/process.go

+)
+
+// allows for testing
+var printFn = fmt.Printf


unused: var printFn is unused

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-25T17:45:23Z

cmd/tsbs_load_questdb/main.go

+var (
+	questdbRESTEndPoint string
+	questdbILPBindTo    string
+	doAbortOnExist      bool


unused: var doAbortOnExist is unused

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-25T17:45:26Z

cmd/tsbs_generate_queries/databases/questdb/devops_test.go

+}
+
+func normaliseField(fieldValue string) string {
+	m1 := regexp.MustCompile("^\\s+")


gosimple: S1007: should use raw string (...) with regexp.MustCompile to avoid having to escape twice

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-25T17:45:27Z

cmd/tsbs_generate_queries/databases/questdb/devops_test.go

+func normaliseField(fieldValue string) string {
+	m1 := regexp.MustCompile("^\\s+")
+	m2 := regexp.MustCompile("\\s+$")
+	m3 := regexp.MustCompile("\\s+")


gosimple: S1007: should use raw string (...) with regexp.MustCompile to avoid having to escape twice

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-25T17:45:28Z

pkg/targets/redistimeseries/serializer.go

+		keyName := fmt.Sprintf("%s%s", hostname, fieldName)
+
+		// if this key was already inserted and created, we don't to specify the labels again
+		if keysSoFar[keyName] == false {


gosimple: S1002: should omit comparison to bool constant, can be simplified to !keysSoFar[keyName]

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-25T17:45:30Z

cmd/tsbs_generate_queries/databases/questdb/devops_test.go

+
+func normaliseField(fieldValue string) string {
+	m1 := regexp.MustCompile("^\\s+")
+	m2 := regexp.MustCompile("\\s+$")


gosimple: S1007: should use raw string (...) with regexp.MustCompile to avoid having to escape twice

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-25T17:45:32Z

cmd/tsbs_run_queries_redistimeseries/functors.go

+			new_query = append(new_query, fmt.Sprintf("%d", ts))
+		}
+		new_query = append(new_query, "FILTER")
+		for _, arg := range commandArgs[7 : len(commandArgs)-4] {


gosimple: S1011: should replace loop with new_query = append(new_query, commandArgs[7:len(commandArgs)-4]...)

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-25T17:45:33Z

cmd/tsbs_run_queries_questdb/main.go

+
+func execQuery(uriRoot string, query string) (QueryResponse, error) {
+	var qr QueryResponse
+	if strings.HasSuffix(uriRoot, "/") {


gosimple: S1017: should replace this if statement with an unconditional strings.TrimSuffix

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-25T17:45:35Z

cmd/tsbs_run_queries_questdb/http_client.go

+
+// NewHTTPClient creates a new HTTPClient.
+func NewHTTPClient(host string) *HTTPClient {
+	if strings.HasSuffix(host, "/") {


gosimple: S1017: should replace this if statement with an unconditional strings.TrimSuffix

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-25T17:45:36Z

cmd/tsbs_load_questdb/creator.go

+
+func execQuery(uriRoot string, query string) (QueryResponse, error) {
+	var qr QueryResponse
+	if strings.HasSuffix(uriRoot, "/") {


gosimple: S1017: should replace this if statement with an unconditional strings.TrimSuffix

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

filipecosta90 force-pushed the master branch from 4687262 to 56292c5 Compare December 21, 2020 12:35

[wip] redistimeseries v1.4 support

3dbb994

filipecosta90 force-pushed the redistimeseries-v1.4 branch from 3e990e8 to 3dbb994 Compare December 21, 2020 12:48

filipecosta90 and others added 27 commits January 3, 2021 22:39

[add] Added LoaderTestResult to persist ingestion benchmark results i…

3006d29

…n a common format across targets

WIP adujst to new APIs

812e461

More work to align RedisTimeSeries code to new TSBS framework

c8a2b19

[fix] Minor fixes on functional RTS script. showcasing the simulated …

d09e8ab

…datapoints progress...

[wip] using radix to ingest. OSS cluster and standalone working.

eb5e4d4

[wip] working on merging tsbs with upstream changes

e9bf8f0

Merge branch 'master' into redistimeseries-v1.4

c35f420

[fix] fixed metric ingestion value for RTS

85cb7eb

[wip] wip on reducing using client work

5c2bdd2

[add] moved from client side work to server-side

e338b96

[wip] improved scripting around redistimeseries tests

243ebdb

[add] Improved load script

0466128

[add] updated default timeframe for 4 full days

2ec34e6

[add] added cluster flag to loader script

bfd57ee

[wip] Enabling cluster mode on rts query runner

ef4a248

use MGET for lastpoint query

30d943e

[add] avoiding pipeline when we only have one command on the slice

9bb285c

[wip] wip on cluster slot issue

5b05cfc

[fix] cluster slots upper limit on radix is exclusivegit add cmd/tsbs…

60044c7

…_load_redistimeseries/main.go ( different from redis spec )

[fix] cluster slots upper limit on radix is exclusivegit add cmd/tsbs…

5b15ccb

…_load_redistimeseries/main.go ( different from redis spec )

[add] small update on RTS scripts

bf41a79

Merge branch 'master' into redistimeseries-v1.4

09496e9

[wip] Improved scripts for RTS

14112b2

[fix] Fixed influxdb runner

f65e197

[fix] Fixed influxdb runner

f81978b

[fix] Fixed influxdb runner

f4a4106

[wip] Improved influx runner

7c6fbba

sonatype-lift bot reviewed Jun 25, 2022

View reviewed changes


		set -x

		EXE_DIR=${EXE_DIR:-$(dirname $0)}

In-Progress Redistimeseries v1.4 support #10

Are you sure you want to change the base?

In-Progress Redistimeseries v1.4 support #10

Uh oh!

Conversation

filipecosta90 commented Dec 21, 2020

Uh oh!

sonatype-lift bot Jun 25, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jun 25, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jun 25, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jun 25, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jun 25, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jun 25, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jun 25, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jun 25, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jun 25, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jun 25, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jun 25, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jun 25, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jun 25, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jun 25, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jun 25, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jun 25, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jun 25, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jun 25, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jun 25, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jun 25, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jun 25, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jun 25, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jun 25, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jun 25, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jun 25, 2022