fix: other ID issues

Author: burythehammer

provider/privatelink/resource_rediscloud_active_active_private_link.go

@@ -66,7 +66,7 @@ func ResourceRedisCloudActiveActivePrivateLink() *schema.Resource {
 						},
 						"principal_type": {
 							Type:             schema.TypeString,
-							ValidateDiagFunc: validation.ToDiagFunc(validation.StringMatch(regexp.MustCompile("^(aws_account|organization|organization_unit|iam_role|iam_user|service_principal)$"), "Must be an allowed Principal Type. ('aws_account', 'organization', 'organization_unit', 'iam_role', 'iam_user')'")),
+							ValidateDiagFunc: validation.ToDiagFunc(validation.StringMatch(regexp.MustCompile("^(aws_account|organization|organization_unit|iam_role|iam_user|service_principal)$"), "Must be an allowed Principal Type. ('aws_account', 'organization', 'organization_unit', 'iam_role', 'iam_user', 'service_principal')'")),
 							Required:         true,
 						},
 						"principal_alias": {
@@ -181,8 +181,6 @@ func resourceRedisCloudActiveActivePrivateLinkCreate(ctx context.Context, d *sch
 		return diag.FromErr(err)
 	}
 
-	d.SetId(strconv.Itoa(subId))
-
 	err = waitForActiveActivePrivateLinkToBeActive(ctx, api, subId, regionId)
 
 	if err != nil {
@@ -226,8 +224,7 @@ func resourceRedisCloudActiveActivePrivateLinkRead(ctx context.Context, d *schem
 	if err != nil {
 		return diag.FromErr(err)
 	}
-
-	err = d.Set("subscription_id", subId)
+	err = d.Set("subscription_id", strconv.Itoa(subId))
 
 	if err != nil {
 		return diag.FromErr(err)
@@ -252,8 +249,6 @@ func resourceRedisCloudActiveActivePrivateLinkRead(ctx context.Context, d *schem
 		return diag.FromErr(err)
 	}
 
-	d.SetId(strconv.Itoa(subId))
-
 	err = d.Set("share_name", privateLink.ShareName)
 	if err != nil {
 		return diag.FromErr(err)