Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserConfig.write is unsafe #21

Closed
favonia opened this issue Jun 28, 2020 · 1 comment
Closed

UserConfig.write is unsafe #21

favonia opened this issue Jun 28, 2020 · 1 comment

Comments

@favonia
Copy link
Collaborator

favonia commented Jun 28, 2020

The module UserConfig cannot serialize library versions correctly because the underlying OCaml binding of libyaml is serializing the string "1.0" as the floating point 1., "null" as null (unquoted), etc. This means users have to manually edit the configuration files.

The bug report to the upstream: avsm/ocaml-yaml#39

@favonia
Copy link
Collaborator Author

favonia commented Jun 17, 2021

Solved by #28 and #30.

@favonia favonia closed this as completed Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant