Fix error checking documented in Issue #45#213
Open
cnsnyder wants to merge 2 commits intoRedHatInsights:release-0.2from
Open
Fix error checking documented in Issue #45#213cnsnyder wants to merge 2 commits intoRedHatInsights:release-0.2from
cnsnyder wants to merge 2 commits intoRedHatInsights:release-0.2from
Conversation
Member
|
Can one of the admins verify this patch? |
Contributor
I think there's a follow-up commit or PR we can introduce here that changes the behavior of the |
DuckBoss
approved these changes
Feb 27, 2025
650578b to
8ed081b
Compare
8ed081b to
112b543
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds checks for the errors potentially returned in a number of places as documented here : #45
This code is not as DRY as I'd like it, all feedback welcome! I hope to solve issues and improve!
Cheers!