Remove judicial district dropdown for ND (#660)

* Remove judicial district dropdown for ND

* Update tests

* Slight adjustment to comments - add note about it being just for ND

---------

Co-authored-by: Mahmoud <[email protected]>

Author: mxosman

spotlight-client/src/LocalityFilterSelect/LocalityFilterSelect.test.tsx

@@ -15,12 +15,11 @@
 // along with this program.  If not, see <https://www.gnu.org/licenses/>.
 // =============================================================================
 
-import { render, screen, fireEvent } from "@testing-library/react";
+import { render, screen } from "@testing-library/react";
 import React from "react";
+import contentFixture from "../contentModels/__fixtures__/tenant_content_exhaustive";
 import createMetricMapping from "../contentModels/createMetricMapping";
 import type PopulationBreakdownByLocationMetric from "../contentModels/PopulationBreakdownByLocationMetric";
-import contentFixture from "../contentModels/__fixtures__/tenant_content_exhaustive";
-import { reactImmediately } from "../testUtils";
 import LocalityFilterSelect from "./LocalityFilterSelect";
 
 const testTenantId = "US_ND";
@@ -57,40 +56,21 @@ test("has expected options", () => {
   const metric = getTestMetric();
   render(<LocalityFilterSelect metric={metric} />);
 
-  const menuButton = screen.getByRole("button", {
+  const menuButton = screen.queryByRole("button", {
     name: "Judicial District All Districts",
   });
-  fireEvent.click(menuButton);
-
-  const options = screen.getAllByRole("option");
-
-  expect(options.length).toBe(expectedLocalities.length);
 
-  options.forEach((option, index) =>
-    expect(option).toHaveTextContent(expectedLocalities[index].label)
-  );
+  expect(menuButton).toBeNull(); // Jurisdiction Dropdowns should no longer display for ND as of February 2025
 });
 
 test("changes demographic filter", () => {
   const metric = getTestMetric();
   render(<LocalityFilterSelect metric={metric} />);
 
-  const menuButton = screen.getByRole("button", {
+  const menuButton = screen.queryByRole("button", {
     name: "Judicial District All Districts",
   });
 
-  expectedLocalities.forEach((expectedLocality) => {
-    // open the menu
-    fireEvent.click(menuButton);
-
-    const option = screen.getByRole("option", { name: expectedLocality.label });
-    fireEvent.click(option);
-
-    reactImmediately(() => {
-      expect(metric.localityId).toBe(expectedLocality.id);
-      expect(menuButton).toHaveTextContent(expectedLocality.label);
-    });
-  });
-
+  expect(menuButton).toBeNull(); // Jurisdiction Dropdowns should no longer display for ND  as of February 2025
   expect.hasAssertions();
 });

spotlight-client/src/LocalityFilterSelect/LocalityFilterSelect.tsx

@@ -39,7 +39,12 @@ const LocalityFilterSelect: React.FC<LocalityFilterSelectProps> = ({
   });
 
   // if there are no locality entries, don't display the dropdown. We are skipping this for Idaho launch. See https://github.com/Recidiviz/public-dashboard/issues/582
-  if (metric.localityLabels.entries.length === 0) {
+  if (
+    metric.localityLabels.entries.length === 0 ||
+    // The judicial district dropdown for ND should no longer be visible in the UI due to unreliable disaggregation data (based on ND dashboard audit)
+    (metric.tenantId === "US_ND" &&
+      metric.localityLabels.label === "Judicial District")
+  ) {
     return null;
   }
 

spotlight-client/src/VizSentenceTypeByLocation/VizSentenceTypeByLocation.test.tsx

@@ -134,11 +134,9 @@ test("locality filter", async () => {
 
   await when(() => !metric.isLoading);
 
-  const menuButton = screen.getByRole("button", {
+  const menuButton = screen.queryByRole("button", {
     name: "Judicial District All Districts",
   });
-  fireEvent.click(menuButton);
-  fireEvent.click(screen.getByRole("option", { name: "South Central" }));
 
-  verifySankey(["Total"], ["1,340", "735", "445"]);
+  expect(menuButton).toBeNull(); // Jurisdiction Dropdowns should no longer display for ND as of February 2025
 });