PHP Warning: Undefined array key "REQUEST_METHOD"

[herrdommel]

After the latest plugin update of Really Simple Security (Version 9.5.8 to 9.5.9) I started to get warning from a cron job.

Cron user@host (/usr/bin/php -f 'httpdocs/wp-cron.php') > /dev/null

PHP Warning: Undefined array key "REQUEST_METHOD" in /var/www/vhosts/redacted/httpdocs/wp-content/plugins/really-simple-ssl/core/app/Support/Helpers/Storages/RequestStorage.php on line 28

WordPress Version: 6.9.4
Server-Architektur: Linux 5.2.0 x86_64
Webserver: Apache
PHP-Version: 8.3.30 (Unterstützt 64bit-Werte)
PHP-SAPI: fpm-fcgi
Maximale PHP-Eingabe-Variablen (max_input_vars): 1000
Maximale PHP-Ausführungszeit (max_execution_time): 30
PHP-Arbeitsspeichergrenze (memory_limit): 256M
Maximale Eingabe-Zeit (max_input_time): 60
Maximale Dateigröße beim Upload (upload_max_filesize): 64M
Maximale Größe der PHP-Post-Daten (post_max_size): 64M
cURL-Version: 7.81.0 OpenSSL/3.0.2

[herrdommel]

The cron job runs every 5 minutes, so I get this warning mail every 5 minutes 😅

[herrdommel]

Not sure why the file on my system looks like this (it looks different in this repo 👀).

<?php

declare(strict_types=1);

namespace ReallySimplePlugins\RSS\Core\Support\Helpers\Storages;

use ReallySimplePlugins\RSS\Core\Support\Helpers\Storage;

/**
 * Request storage helper used in DI container.
 */
final class RequestStorage extends Storage
{
    public function __construct()
    {
        $body = $this->getRequestBody();

        parent::__construct([
            'global' => $_REQUEST,
            'files' => $_FILES,
            'body' => $body,
        ]);
    }

    private function getRequestBody(): array
    {
        $body = [];
        if ($_SERVER['REQUEST_METHOD'] !== 'GET') {
            $input = file_get_contents('php://input');
            $decoded = json_decode($input, true);
            if (is_array($decoded)) {
                $body = $decoded;
            }
        }                                                                                                                                                     
        return $body;
    }
}

Here's my workaround

$body = [];
$requestMethod = $_SERVER['REQUEST_METHOD'] ?? 'GET';

//if ($_SERVER['REQUEST_METHOD'] !== 'GET') {
if ($requestMethod !== 'GET') {

[herrdommel]

Not sure why the file on my system looks like this (it looks different in this repo 👀).

Ah this file changed in v9.5.9.

[mwolters90]

Hi @herrdommel,

thank you for reporting this issue. We have created a fix for it which will be included in a future release.