Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter structure not to spec #24

Open
letmaik opened this issue Oct 14, 2016 · 2 comments
Open

Parameter structure not to spec #24

letmaik opened this issue Oct 14, 2016 · 2 comments
Labels

Comments

@letmaik
Copy link
Contributor

letmaik commented Oct 14, 2016

The parameter structure that is generated from pycovjson-convert is:

    {
      "symbol": {
        "value": "Land Cover Class",
        "type": ""
      },
      "description": null,
      "observedProperty": {
        "id": null,
        "label": {
          "en": "MELODIES Land Cover"
        }
      },
      "type": "Parameter",
      "unit": {
        "label": {
          "en": "Land Cover Class"
        }
      }
    }

There are several issues here:

  • "symbol" can only be defined within the "unit" property, so the nesting is wrong.
  • The value of "type" within "symbol" cannot be an empty string. If the unit scheme is not known as in here, then the symbol must be a plain string, not an object.
  • null is not allowed for missing values (here "description" and "id"). The property has to be left out completely in that case.
@letmaik letmaik added the bug label Oct 14, 2016
@RileyWilliams
Copy link
Collaborator

what is the "id" field used for?

@letmaik
Copy link
Contributor Author

letmaik commented Oct 24, 2016

It's just a string identifier, sometimes it can be a URI identifiying some concept globally uniquely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants