Skip to content
This repository was archived by the owner on Apr 20, 2018. It is now read-only.

Commit 4c852e3

Browse files
Fixing Issue #15
1 parent 2c5e4f6 commit 4c852e3

File tree

3 files changed

+15
-9
lines changed

3 files changed

+15
-9
lines changed

rx.jquery.js

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,14 +91,15 @@
9191
* @returns {Observable} An Observable sequence which wraps the jQuery on method.
9292
*/
9393
proto.onAsObservable = function () {
94-
var parent = this, args = slice.call(arguments, 0);
94+
var parent = this, oargs = slice.call(arguments, 0), args;
9595
return observableCreateRefCount(function(observer) {
9696

9797
function handler(eventObject) {
9898
eventObject.additionalArguments = slice.call(arguments, 1);
9999
observer.onNext(eventObject);
100100
}
101101

102+
args = oargs.slice();
102103
args.push(handler);
103104

104105
parent.on.apply(parent, args);
@@ -405,15 +406,17 @@
405406
* @returns {Observable} An Observable sequence which wraps the jQuery one method.
406407
*/
407408
proto.oneAsObservable = function(events) {
408-
var parent = this, args = arguments;
409-
return observableCreate(function(observer) {
409+
var parent = this, oargs = slice.call(arguments, 0), args;
410+
return observableCreateRefCount(function(observer) {
410411

411412
function handler (eventObject) {
412413
eventObject.additionalArguments = slice.call(arguments, 1);
413414
observer.onNext(eventObject);
414415
}
415416

417+
args = oargs.slice();
416418
args.push(handler);
419+
417420
parent.one.apply(parent, args);
418421
});
419422
};
@@ -425,7 +428,7 @@
425428
*/
426429
proto.readyAsObservable = function() {
427430
var parent = this;
428-
return observableCreate(function(observer) {
431+
return observableCreateRefCount(function(observer) {
429432

430433
function handler(eventObject) {
431434
observer.onNext(eventObject);

rx.jquery.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/events.js

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,15 @@
88
* @returns {Observable} An Observable sequence which wraps the jQuery on method.
99
*/
1010
proto.onAsObservable = function () {
11-
var parent = this, args = slice.call(arguments, 0);
11+
var parent = this, oargs = slice.call(arguments, 0), args;
1212
return observableCreateRefCount(function(observer) {
1313

1414
function handler(eventObject) {
1515
eventObject.additionalArguments = slice.call(arguments, 1);
1616
observer.onNext(eventObject);
1717
}
1818

19+
args = oargs.slice();
1920
args.push(handler);
2021

2122
parent.on.apply(parent, args);
@@ -322,15 +323,17 @@
322323
* @returns {Observable} An Observable sequence which wraps the jQuery one method.
323324
*/
324325
proto.oneAsObservable = function(events) {
325-
var parent = this, args = arguments;
326-
return observableCreate(function(observer) {
326+
var parent = this, oargs = slice.call(arguments, 0), args;
327+
return observableCreateRefCount(function(observer) {
327328

328329
function handler (eventObject) {
329330
eventObject.additionalArguments = slice.call(arguments, 1);
330331
observer.onNext(eventObject);
331332
}
332333

334+
args = oargs.slice();
333335
args.push(handler);
336+
334337
parent.one.apply(parent, args);
335338
});
336339
};
@@ -342,7 +345,7 @@
342345
*/
343346
proto.readyAsObservable = function() {
344347
var parent = this;
345-
return observableCreate(function(observer) {
348+
return observableCreateRefCount(function(observer) {
346349

347350
function handler(eventObject) {
348351
observer.onNext(eventObject);

0 commit comments

Comments
 (0)