-
Notifications
You must be signed in to change notification settings - Fork 99
TypeScript definition file #18
Comments
@Igorbek any plans on making one for this project? |
I'll arrange my plan to make it this week (or, probably, the following week). |
@Igorbek It seems the type definition file is still missing. Would you mind if I work on it? |
I've created one but I'm not sure about it. https://gist.github.com/crissdev/56fda2b80011093e0171 EDIT Updated Typescript definition file with what's currently documented. |
@david-driscoll Could you by chance help me with the TS typings for RxJS-DOM? |
Sure, if I have time tonight I'll work on this one. On Mon, Oct 5, 2015 at 10:40 AM, Matthew Podwysocki <
|
Here's my take: https://gist.github.com/oliverw/a3ba9d804d848417fac4 |
Nice! I can review if needed in a day or two (depends if I find time while On Mon, Oct 26, 2015 at 9:29 AM Oliver Weichhold [email protected]
|
@oliverw, thank you for the def file! Would you please consider submit it to DefinitelyTyped so that everyone can benefit from it? @david-driscoll, any thoughts on the definition file? Thanks. |
only comment would be that the definitions like function blur(element: Element, selector?:Function, useCapture?:boolean):Rx.Observable<FocusEvent>; assuming selector modifies the value sent out as the observable, they could be broken out into... function blur(element: Element): Rx.Observable<FocusEvent>;
function blur<T>(element: Element, selector?: (e: FocusEvent) => T, useCapture?:boolean): Rx.Observable<T>; |
I am trying to use your version @oliverw, I am doing: It's always undefined. |
No description provided.
The text was updated successfully, but these errors were encountered: