-
Notifications
You must be signed in to change notification settings - Fork 238
Aromaticity detection problems in thermo? #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
My understanding is that aromaticity perception in RMG-Py is somewhere between incomplete and nonexistent (or maybe sitting on an unmerged branch somewhere?), hence the problem. Probably porting over the RMG-Java algorithm as-is would be a reasonable start. |
Was an aromaticity perception function ever written on the QMthermo branch? |
at least not by me. On Fri, Jan 18, 2013 at 5:21 PM, Connie Gao [email protected]:
e-mail: [email protected] |
Nor by me. |
Now that we are incorporating RDKit and relying on it quite heavily (on a topic branch, soon to be merged - #135) I wonder if it would make sense to use their aromaticity perception code? I think we should at least look into it. |
This closes #135 - Switch from OpenBabel to RDKit And also... closes #86 - Drawing of fused rings buggy closes #90 - molecule.fromSMILES(CC1=CC=CO1) gives "Unable to determine atom type for atom O." closes #121 - Furan inchi and SMILES cannot be resolved Should help with #106 in the future (I think RDKit has aromaticity detection). RDKit is now a requirement (but OpenBabel no longer is). Be sure to install RDKit with InChI Support, which at the moment requires building from source, I think. Note that anything being read in via InChI or SMILES will be Kekulized before making the RMG molecule. This means if you input benzene as SMILES="c1ccccc1" it will be equivalent to SMILES="C1=CC=CC=C1"
Any updates on what to do regarding aromaticity perception? At this point we have removed all aromaticity (no Cb bonds are kept), so we are no longer picking up benzene thermo nor aromatic-specific kinetics. Another question is- after kekulization of benzene, do we always allow RMG to pick up regular single/double bond kinetics even though it is benzene? |
The ability to react aromatic bonds is no worse than it was - just specify the Cb bonds in adjacency list format not SMILES. However, that ability is not great. We don't perceive aromaticity, and cannot make benzene from scratch. |
Currently closed via #322 |
Compare the thermo for the kekulized benzene
http://rmg.mit.edu/database/thermo/molecule/1%20C%200%20%7B2,S%7D%20%7B6,D%7D%0D%0A2%20C%200%20%7B1,S%7D%20%7B3,D%7D%0D%0A3%20C%200%20%7B2,D%7D%20%7B4,S%7D%0D%0A4%20C%200%20%7B3,S%7D%20%7B5,D%7D%0D%0A5%20C%200%20%7B4,D%7D%20%7B6,S%7D%0D%0A6%20C%200%20%7B1,D%7D%20%7B5,S%7D%0D%0A
with the aromatic version
http://rmg.mit.edu/database/thermo/molecule/1%20C%200%20%7B2,B%7D%20%7B6,B%7D%0D%0A2%20C%200%20%7B1,B%7D%20%7B3,B%7D%0D%0A3%20C%200%20%7B2,B%7D%20%7B4,B%7D%0D%0A4%20C%200%20%7B3,B%7D%20%7B5,B%7D%0D%0A5%20C%200%20%7B4,B%7D%20%7B6,B%7D%0D%0A6%20C%200%20%7B1,B%7D%20%7B5,B%7D%0D%0A
Not sure how widespread this is, or what the consequences are for building models.
(Does it depend on how we define our reactants?)
What if we make an aromatic thing via reactions from non-aromatic things - do we detect it?
The text was updated successfully, but these errors were encountered: