Skip to content

Commit fd3db97

Browse files
Jing-yilinclaude
andcommitted
Windows app: no white menu strip, a publisher, and a release that starts it
Three things seen with the 1.5.2 installer on a real Windows 11 machine. The default Electron menu draws as a white strip across the black app. autoHideMenuBar hides it until Alt, and does nothing on macOS, where the menu is not in the window. Apps and features listed the app with no publisher. electron-builder takes it from `author`, which desktop/package.json did not have. The name is the one the plugin manifests already carry. The release built the installer and attached it without ever running it, and 1.5.2's answered 404 for every page. The nsis job now installs it silently, starts the app on a project and fetches the front page before it uploads anything. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
1 parent 5b8be51 commit fd3db97

3 files changed

Lines changed: 8 additions & 1 deletion

File tree

‎.github/workflows/release.yml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -478,4 +478,8 @@ jobs:
478478
bun install --frozen-lockfile
479479
bun run build
480480
bunx electron-builder --win nsis --x64 --publish never
481+
# The installer is what people run, and nothing else starts it before they do.
482+
MSYS_NO_PATHCONV=1 dist/out/*.exe /S
483+
"$LOCALAPPDATA/Programs/super-prototyping-desktop/Super Prototyping.exe" --port 5199 "$(mktemp -d)" &
484+
curl --retry 60 --retry-connrefused --retry-delay 1 -fsS http://127.0.0.1:5199/ | grep -q 'id="root"'
481485
gh release upload "super-prototyping--v$VERSION" dist/out/*.exe

‎desktop/main.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,8 @@ async function main() {
9797
height: 900,
9898
title: "Super Prototyping",
9999
backgroundColor: "#000000",
100+
// Windows draws the menu as a white strip across a black app. Alt still shows it.
101+
autoHideMenuBar: true,
100102
webPreferences: { preload: path.join(app.getAppPath(), "dist/preload.cjs") },
101103
});
102104
let project = argDir;

‎desktop/package.json‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
"name": "super-prototyping-desktop",
33
"private": true,
44
"version": "1.5.2",
5-
"description": "The super-prototyping canvas as a macOS app",
5+
"description": "The super-prototyping canvas as a desktop app",
6+
"author": "ReScience Lab",
67
"type": "module",
78
"main": "dist/main.mjs",
89
"scripts": {

0 commit comments

Comments
 (0)