Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Book 3] Incorrect number of samples written for mixture density #1642

Open
berkowitze opened this issue Sep 22, 2024 · 0 comments
Open

[Book 3] Incorrect number of samples written for mixture density #1642

berkowitze opened this issue Sep 22, 2024 · 0 comments

Comments

@berkowitze
Copy link

[Minor]

Relatively sure the image here was generated with 10 samples, not 1000. Just was a bit confused because my image has a lot less noise.

Updating `main.cc` to 1000 samples per pixel (not listed) yields:

Book image:
image

My program with 1000 samples:
image

My program with 10 samples:
image

Happy to fix.

@hollasch hollasch self-assigned this Nov 12, 2024
@hollasch hollasch added this to the v4.0.2 milestone Nov 12, 2024
@hollasch hollasch removed their assignment Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants