New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Book 3 12.4 missing modification in `ray_color` to sample glass ball #1639

Open

jianjianh1 opened this issue Sep 13, 2024 · 0 comments

Milestone

jianjianh1 commented Sep 13, 2024 •

edited

Loading

The section changes the sphere class to let us shoot sample ray to the glass ball, but the ray_color function doesn't change any sampling scheme.

Furthermore, it mentions

It took five times as long as sampling the light did for my code. This is probably because those rays that hit the glass are expensive!

So I believe the modification in ray_color is missing.

The text was updated successfully, but these errors were encountered:

hollasch self-assigned this

hollasch added this to the v4.0.2 milestone

hollasch removed their assignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment